lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3017291c-f600-4810-8d6e-8d9ef7a8d43f@kernel.org>
Date: Wed, 6 Mar 2024 09:48:38 +0800
From: Chao Yu <chao@...nel.org>
To: Roman Smirnov <r.smirnov@....ru>, Jaegeuk Kim <jaegeuk@...nel.org>
Cc: Sergey Shtylyov <s.shtylyov@....ru>, Karina Yankevich
 <k.yankevich@....ru>, linux-f2fs-devel@...ts.sourceforge.net,
 linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] f2fs: Cast expression type to unsigned long in
 __count_extent_cache()

On 2024/3/5 16:09, Roman Smirnov wrote:
> Cast expression type to unsigned long in __count_extent_cache()
> to prevent integer overflow.
> 
> Found by Linux Verification Center (linuxtesting.org) with Svace.
> 
> Signed-off-by: Roman Smirnov <r.smirnov@....ru>
> Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

Reviewed-by: Chao Yu <chao@...nel.org>

Thanks,

> ---
>   fs/f2fs/shrinker.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/shrinker.c b/fs/f2fs/shrinker.c
> index 83d6fb97dcae..bb86a06c5d5e 100644
> --- a/fs/f2fs/shrinker.c
> +++ b/fs/f2fs/shrinker.c
> @@ -33,7 +33,7 @@ static unsigned long __count_extent_cache(struct f2fs_sb_info *sbi,
>   {
>   	struct extent_tree_info *eti = &sbi->extent_tree[type];
>   
> -	return atomic_read(&eti->total_zombie_tree) +
> +	return (unsigned long)atomic_read(&eti->total_zombie_tree) +
>   				atomic_read(&eti->total_ext_node);
>   }
>   

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ