linux-kernel - Re: [PATCH] pps: use cflags-y instead of EXTRA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b10e330a-ca9e-47b9-a80f-3dc350e6c502@enneenne.com>
Date: Wed, 6 Mar 2024 13:18:46 +0100
From: Rodolfo Giometti <giometti@...eenne.com>
To: Lukas Bulwahn <lukas.bulwahn@...il.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pps: use cflags-y instead of EXTRA_CFLAGS

On 06/03/24 13:05, Lukas Bulwahn wrote:
> Commit f77bf01425b1 ("kbuild: introduce ccflags-y, asflags-y and
> ldflags-y") deprecates use of EXTRA_CFLAGS in the kernel build.
> 
> This has been cleaned up in the whole kernel tree long ago, but this one
> single place must have been missed.
> 
> Replace the EXTRA_CFLAGS use by the common pattern for such debug flags.
> No functional change.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>

Acked-by: Rodolfo Giometti <giometti@...eenne.com>

> ---
> Rodolfo, please ack.
> 
> Greg, please pick this minor cleanup patch.
> 
>   drivers/pps/generators/Makefile | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/pps/generators/Makefile b/drivers/pps/generators/Makefile
> index 2d56dd0495d5..2589fd0f2481 100644
> --- a/drivers/pps/generators/Makefile
> +++ b/drivers/pps/generators/Makefile
> @@ -5,6 +5,4 @@
>   
>   obj-$(CONFIG_PPS_GENERATOR_PARPORT) += pps_gen_parport.o
>   
> -ifeq ($(CONFIG_PPS_DEBUG),y)
> -EXTRA_CFLAGS += -DDEBUG
> -endif
> +ccflags-$(CONFIG_PPS_DEBUG) := -DDEBUG

-- 
GNU/Linux Solutions                  e-mail: giometti@...eenne.com
Linux Device Driver                          giometti@...ux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming