linux-kernel - Re: [PATCH v4 2/9] dt-bindings: usb: ti,j721e-usb: add ti,j7200-usb compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CZNLOCAIE6P7.1BJ23DWJPCSHS@bootlin.com>
Date: Thu, 07 Mar 2024 15:50:21 +0100
From: Théo Lebrun <theo.lebrun@...tlin.com>
To: "Rob Herring" <robh@...nel.org>
Cc: "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>, "Krzysztof Kozlowski"
 <krzysztof.kozlowski+dt@...aro.org>, "Conor Dooley" <conor+dt@...nel.org>,
 "Roger Quadros" <rogerq@...nel.org>, "Peter Chen" <peter.chen@...nel.org>,
 "Pawel Laszczak" <pawell@...ence.com>, "Nishanth Menon" <nm@...com>,
 "Vignesh Raghavendra" <vigneshr@...com>, "Tero Kristo" <kristo@...nel.org>,
 "Thomas Petazzoni" <thomas.petazzoni@...tlin.com>,
 Grégory Clement <gregory.clement@...tlin.com>, "Kevin
 Hilman" <khilman@...nel.org>, "Alan Stern" <stern@...land.harvard.edu>,
 <linux-usb@...r.kernel.org>, <devicetree@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v4 2/9] dt-bindings: usb: ti,j721e-usb: add ti,j7200-usb
 compatible

Hello Rob,

On Thu Mar 7, 2024 at 3:21 PM CET, Rob Herring wrote:
> On Thu, Mar 07, 2024 at 10:55:03AM +0100, Théo Lebrun wrote:
> > On J7200, the controller & its wrapper are reset on resume. It has the
> > same behavior as ti,j721e-usb with a different SoC integration.
> > 
> > Signed-off-by: Théo Lebrun <theo.lebrun@...tlin.com>
> > ---
> >  Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
> > index 653a89586f4e..e8f7e7511483 100644
> > --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
> > +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
> > @@ -16,6 +16,9 @@ properties:
> >        - items:
> >            - const: ti,am64-usb
> >            - const: ti,j721e-usb
> > +      - items:
> > +          - const: ti,j7200-usb
> > +          - const: ti,j721e-usb
>
> Combine this with the previous entry:
>
> items:
>   - enum:
>       - ti,am64-usb
>       - ti,j7200-usb
>   - const: ti,j721e-usb

Makes sense, will do. Full block will become:

	properties:
	  compatible:
	    oneOf:
	      - const: ti,j721e-usb
	      - items:
	          - enum:
	              - const: ti,am64-usb
	              - const: ti,j7200-usb
	          - const: ti,j721e-usb

Thanks,

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com