linux-kernel - Re: [PATCH] mmc: dw_mmc: remove unneeded assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e34b5334-48c3-4ebd-9a1a-7ea26899d304@moroto.mountain>
Date: Thu, 7 Mar 2024 18:01:36 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>
Cc: Yang Xiwen <forbidden405@...look.com>, kernel@...labora.com,
	kernel-janitors@...r.kernel.org, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Jaehoon Chung <jh80.chung@...sung.com>,
	Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH] mmc: dw_mmc: remove unneeded assignment

On Thu, Mar 07, 2024 at 07:51:37PM +0500, Muhammad Usama Anjum wrote:
> On 3/7/24 5:22 PM, Yang Xiwen wrote:
> > On 3/7/2024 8:21 PM, Muhammad Usama Anjum wrote:
> >> The err is being set to 0 and replaced every time after this
> >> assignment. Remove this assignment as it is extraneous.
> >>
> >> Fixes: 25d043841db1 ("mmc: dw_mmc: add support for hi3798mv200")
> >> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
> >> ---
> >>   drivers/mmc/host/dw_mmc-hi3798mv200.c | 1 -
> >>   1 file changed, 1 deletion(-)
> >>
> >> diff --git a/drivers/mmc/host/dw_mmc-hi3798mv200.c
> >> b/drivers/mmc/host/dw_mmc-hi3798mv200.c
> >> index 989ae8dda7228..96af693e3e37c 100644
> >> --- a/drivers/mmc/host/dw_mmc-hi3798mv200.c
> >> +++ b/drivers/mmc/host/dw_mmc-hi3798mv200.c
> >> @@ -133,7 +133,6 @@ static int
> >> dw_mci_hi3798mv200_execute_tuning_mix_mode(struct dw_mci_slot *slot,
> >>               goto tuning_out;
> >>             prev_err = err;
> >> -        err = 0;
> > 
> > 
> > Same for dw_mmc-hi3798cv200.c, maybe fix it as well?
> Sent separately as different Fixes tag is required for that:
> https://lore.kernel.org/all/20240307145013.2721326-1-usama.anjum@collabora.com
> 

The subjects are identical though.

regards,
dan carpenter