linux-kernel - Re: [PATCH v5 4/6] MAINTAINERS: add entry for DCP-based trusted keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <2E9B3F32-B162-4C84-81AD-5713EB53A85D@sigma-star.at>
Date: Thu, 7 Mar 2024 16:34:53 +0100
From: David Gstir <david@...ma-star.at>
To: Jarkko Sakkinen <jarkko@...nel.org>
Cc: Mimi Zohar <zohar@...ux.ibm.com>,
 James Bottomley <jejb@...ux.ibm.com>,
 Herbert Xu <herbert@...dor.apana.org.au>,
 "David S. Miller" <davem@...emloft.net>,
 Shawn Guo <shawnguo@...nel.org>,
 Jonathan Corbet <corbet@....net>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 "kernel@...gutronix.de" <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>,
 NXP Linux Team <linux-imx@....com>,
 Ahmad Fatoum <a.fatoum@...gutronix.de>,
 sigma star Kernel Team <upstream+dcp@...ma-star.at>,
 David Howells <dhowells@...hat.com>,
 Li Yang <leoyang.li@....com>,
 Paul Moore <paul@...l-moore.com>,
 James Morris <jmorris@...ei.org>,
 "Serge E. Hallyn" <serge@...lyn.com>,
 "Paul E. McKenney" <paulmck@...nel.org>,
 Randy Dunlap <rdunlap@...radead.org>,
 Catalin Marinas <catalin.marinas@....com>,
 "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
 Tejun Heo <tj@...nel.org>,
 "Steven Rostedt (Google)" <rostedt@...dmis.org>,
 linux-doc@...r.kernel.org,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
 "keyrings@...r.kernel.org" <keyrings@...r.kernel.org>,
 "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
 linux-arm-kernel@...ts.infradead.org,
 linuxppc-dev@...ts.ozlabs.org,
 "linux-security-module@...r.kernel.org" <linux-security-module@...r.kernel.org>
Subject: Re: [PATCH v5 4/6] MAINTAINERS: add entry for DCP-based trusted keys

Jarkko,

> On 04.03.2024, at 23:48, Jarkko Sakkinen <jarkko@...nel.org> wrote:
> 
> On Fri Dec 15, 2023 at 1:06 PM EET, David Gstir wrote:
>> This covers trusted keys backed by NXP's DCP (Data Co-Processor) chip
>> found in smaller i.MX SoCs.
>> 
>> Signed-off-by: David Gstir <david@...ma-star.at>
>> ---
>> MAINTAINERS | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>> 
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 90f13281d297..988d01226131 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -11647,6 +11647,15 @@ S: Maintained
>> F: include/keys/trusted_caam.h
>> F: security/keys/trusted-keys/trusted_caam.c
>> 
>> +KEYS-TRUSTED-DCP
>> +M: David Gstir <david@...ma-star.at>
>> +R: sigma star Kernel Team <upstream+dcp@...ma-star.at>
>> +L: linux-integrity@...r.kernel.org
>> +L: keyrings@...r.kernel.org
>> +S: Supported
>> +F: include/keys/trusted_dcp.h
>> +F: security/keys/trusted-keys/trusted_dcp.c
>> +
>> KEYS-TRUSTED-TEE
>> M: Sumit Garg <sumit.garg@...aro.org>
>> L: linux-integrity@...r.kernel.org
> 
> Acked-by: Jarkko Sakkinen <jarkko@...nel.org>
> 
> I can for sure put this. The code quality is *not* bad :-) However, your
> backing story really needs rework. It is otherwise impossible to
> understand the code changes later on because amount of information is
> vast, and you tend to forget details of stuff that you are not actively
> working on. That is why we care so deeply about them.

got it! :) I’ve tried to rework the commit messages as good as possible
for v6 and will send that series momentarily.

Thanks!
- David