linux-kernel - Re: [PATCH v1 1/2] spi: pxa2xx: Kill pxa2xx_set_spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <fd47619b-e61f-4d89-af4c-5c967fa1ec2d@app.fastmail.com>
Date: Thu, 07 Mar 2024 17:47:56 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-spi@...r.kernel.org, "Daniel Mack" <daniel@...que.org>,
 "Haojian Zhuang" <haojian.zhuang@...il.com>,
 "Robert Jarzmik" <robert.jarzmik@...e.fr>,
 "Russell King" <linux@...linux.org.uk>, "Mark Brown" <broonie@...nel.org>
Subject: Re: [PATCH v1 1/2] spi: pxa2xx: Kill pxa2xx_set_spi_info()

On Thu, Mar 7, 2024, at 17:42, Andy Shevchenko wrote:
> On Thu, Mar 07, 2024 at 05:30:10PM +0100, Arnd Bergmann wrote:
>> On Thu, Mar 7, 2024, at 17:07, Andy Shevchenko wrote:
>> >  	spi_register_board_info(ARRAY_AND_SIZE(spitz_spi_devices));
>> 
>> I think the normal interface these days would be
>> platform_device_register_data(), which does it all in one step.
>
> I'm not sure how is this related to the SPI board info registration.

It's not. What I meant is that you could use
platform_device_register_data() instead of the
"platform_device_alloc(); platform_data = info; platform_device_add();"
sequence.

It should be a safe conversion, but it's also fine to stay
with the existing version if you are worried about regressions.

      Arnd