linux-kernel - Re: [PATCH][next] usb: gadget: net2272: remove redundant variable irqflags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 7 Mar 2024 17:46:31 +0000
From: "Colin King (gmail)" <colin.i.king@...il.com>
To: Alan Stern <stern@...land.harvard.edu>,
 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 linux-usb@...r.kernel.org, kernel-janitors@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] usb: gadget: net2272: remove redundant variable
 irqflags

On 07/03/2024 17:29, Alan Stern wrote:
> On Thu, Mar 07, 2024 at 05:51:59PM +0100, Uwe Kleine-König wrote:
>> On Thu, Mar 07, 2024 at 10:51:35AM +0000, Colin Ian King wrote:
>>> The variable irqflags is being initialized and being bit-or'd with
>>> values but it is never read afterwards. The variable is redundant
>>> and can be removed.
>>>
>>> Cleans up clang scan build warning:
>>> drivers/usb/gadget/udc/net2272.c:2610:15: warning: variable 'irqflags'
>>> set but not used [-Wunused-but-set-variable]
>>>
>>> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
>>
>> this "problem" exists since the driver was introduced in commit
>> ceb80363b2ec ("USB: net2272: driver for PLX NET2272 USB device
>> controller"). Might be worth a Fixes: line.
>>
>> I wonder if the better fix would be:
>>
>> diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c
>> index 12e76bb62c20..19bbc38f3d35 100644
>> --- a/drivers/usb/gadget/udc/net2272.c
>> +++ b/drivers/usb/gadget/udc/net2272.c
>> @@ -2650,7 +2650,7 @@ net2272_plat_probe(struct platform_device *pdev)
>>   		goto err_req;
>>   	}
>>   
>> -	ret = net2272_probe_fin(dev, IRQF_TRIGGER_LOW);
>> +	ret = net2272_probe_fin(dev, irqflags);
>>   	if (ret)
>>   		goto err_io;
> 
> I agree, that makes much more sense.

OK, I'll send a V2, but I can't test it, so I suspect that is a risk, 
but it is clearly wrong as it stands.

Colin

> 
> Alan Stern