linux-kernel - [PATCH][next][V2] usb: gadget: net2272: Use irqflags in the call to net2272_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240307181734.2034407-1-colin.i.king@gmail.com>
Date: Thu,  7 Mar 2024 18:17:34 +0000
From: Colin Ian King <colin.i.king@...il.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	Roy Huang <roy.huang@...log.com>,
	Ash Aziz <ash.aziz@...tech.com>,
	Mike Frysinger <vapier@...too.org>,
	Seth Levy <seth.levy@...tech.com>,
	linux-usb@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH][next][V2] usb: gadget: net2272: Use irqflags in the call to net2272_probe_fin

Currently the variable irqflags is being set but is not being used,
it appears it should be used in the call to net2272_probe_fin
rather than IRQF_TRIGGER_LOW being used. Kudos to Uwe Kleine-König
for suggesting the fix.

Cleans up clang scan build warning:
drivers/usb/gadget/udc/net2272.c:2610:15: warning: variable 'irqflags'
set but not used [-Wunused-but-set-variable]

Fixes: ceb80363b2ec ("USB: net2272: driver for PLX NET2272 USB device controller")

Signed-off-by: Colin Ian King <colin.i.king@...il.com>
---

V2: don't remove irqflags but instead use it in the call to net2272_probe_fin

---
 drivers/usb/gadget/udc/net2272.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c
index 12e76bb62c20..19bbc38f3d35 100644
--- a/drivers/usb/gadget/udc/net2272.c
+++ b/drivers/usb/gadget/udc/net2272.c
@@ -2650,7 +2650,7 @@ net2272_plat_probe(struct platform_device *pdev)
 		goto err_req;
 	}
 
-	ret = net2272_probe_fin(dev, IRQF_TRIGGER_LOW);
+	ret = net2272_probe_fin(dev, irqflags);
 	if (ret)
 		goto err_io;
 
-- 
2.39.2