linux-kernel - Re: [PATCH v2 7/7] sparc32: Fix section mismatch in leon_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5654b69-209e-4406-ac70-9a4547adfc36@gaisler.com>
Date: Thu, 7 Mar 2024 19:20:11 +0100
From: Andreas Larsson <andreas@...sler.com>
To: sam@...nborg.org, "Maciej W. Rozycki" <macro@...am.me.uk>,
 sparclinux@...r.kernel.org, Randy Dunlap <rdunlap@...radead.org>
Cc: Miquel Raynal <miquel.raynal@...tlin.com>,
 linux-parport@...ts.infradead.org, "David S. Miller" <davem@...emloft.net>,
 Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
 Arvind Yadav <arvind.yadav.cs@...il.com>
Subject: Re: [PATCH v2 7/7] sparc32: Fix section mismatch in leon_pci_grpci

On 2024-03-05 16:06, Andreas Larsson wrote:
> On 2024-02-24 18:42, Sam Ravnborg via B4 Relay wrote:
>> From: Sam Ravnborg <sam@...nborg.org>
>>
>> Passing a datastructre marked _initconst to platform_driver_register()
>> is wrong. Drop the __initconst notation.
>>
>> This fixes the following warnings:
>>
>> WARNING: modpost: vmlinux: section mismatch in reference: grpci1_of_driver+0x30 (section: .data) -> grpci1_of_match (section: .init.rodata)
>> WARNING: modpost: vmlinux: section mismatch in reference: grpci2_of_driver+0x30 (section: .data) -> grpci2_of_match (section: .init.rodata)
>>
>> Signed-off-by: Sam Ravnborg <sam@...nborg.org>
>> Cc: "David S. Miller" <davem@...emloft.net>
>> Cc: Andreas Larsson <andreas@...sler.com>
> 
> Could you also add
> 
> Fixes: 4154bb821f0b ("sparc: leon: grpci1: constify of_device_id")
> Fixes: 03949b1cb9f1 ("sparc: leon: grpci2: constify of_device_id")
> 
> for these fixes in your v3 of the series as well as CCing stable?

I'll pick up the whole series apart for the ZONE_DMA removal, so there
is no other need for a v3. I can add the Fixes lines to this one, if it
is ok with you Sam, or take it as is.

Thanks,
Andreas