linux-kernel - Re: [PATCH v14 1/3] dt-bindings: hwmon: fan: Add fan binding to schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 7 Mar 2024 10:46:47 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Billy Tsai <billy_tsai@...eedtech.com>
Cc: jdelvare@...e.com, robh+dt@...nel.org,
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
	joel@....id.au, andrew@...econstruct.com.au, corbet@....net,
	u.kleine-koenig@...gutronix.de, p.zabel@...gutronix.de,
	naresh.solanki@...ements.com, linux-hwmon@...r.kernel.org,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-pwm@...r.kernel.org,
	BMC-SW@...eedtech.com, patrick@...cx.xyz,
	Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v14 1/3] dt-bindings: hwmon: fan: Add fan binding to
 schema

On Wed, Feb 21, 2024 at 06:40:23PM +0800, Billy Tsai wrote:
> From: Naresh Solanki <naresh.solanki@...ements.com>
> 
> Add common fan properties bindings to a schema.
> 
> Bindings for fan controllers can reference the common schema for the
> fan
> 
> child nodes:
> 
>   patternProperties:
>     "^fan@[0-2]":
>       type: object
>       $ref: fan-common.yaml#
>       unevaluatedProperties: false
> 
> Reviewed-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Naresh Solanki <naresh.solanki@...ements.com>
> Signed-off-by: Billy Tsai <billy_tsai@...eedtech.com>

Applied to hwmon-next. There have been a couple of questions, specifically:

- min-rpm of 1000 seems low. Fans with higher minimum RPM
  are known to exist.
- A default value of '2' was suggested for pulses-per-revolution.

Those questions can be addressed with subsequent patches if needed.

Guenter