[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <771b185f-98ee-475d-8075-86399b3dfe09@roeck-us.net>
Date: Thu, 7 Mar 2024 10:51:48 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Billy Tsai <billy_tsai@...eedtech.com>
Cc: jdelvare@...e.com, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
joel@....id.au, andrew@...econstruct.com.au, corbet@....net,
u.kleine-koenig@...gutronix.de, p.zabel@...gutronix.de,
naresh.solanki@...ements.com, linux-hwmon@...r.kernel.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
linux-doc@...r.kernel.org, linux-pwm@...r.kernel.org,
BMC-SW@...eedtech.com, patrick@...cx.xyz
Subject: Re: [PATCH v14 3/3] hwmon: (aspeed-g6-pwm-tacho): Support for ASPEED
g6 PWM/Fan tach
On Wed, Feb 21, 2024 at 06:40:25PM +0800, Billy Tsai wrote:
> The driver support two functions: PWM and Tachometer. The PWM feature can
> handle up to 16 output ports, while the Tachometer can monitor to up to 16
> input ports as well. This driver implements them by exposing two kernel
> subsystems: PWM and HWMON. The PWM subsystem can be utilized alongside
> existing drivers for controlling elements such as fans (pwm-fan.c),
> beepers (pwm-beeper.c) and so on. Through the HWMON subsystem, the driver
> provides sysfs interfaces for fan.
>
> Signed-off-by: Billy Tsai <billy_tsai@...eedtech.com>
Applied to hwmon-next. There was an outstanding suggestion:
> > +static int aspeed_pwm_tach_remove(struct platform_device *pdev)
> > +{
> > + struct aspeed_pwm_tach_data *priv = platform_get_drvdata(pdev);
> > +
> > + reset_control_assert(priv->reset);
>
> This is already done by aspeed_pwm_tach_reset_assert(), looks like
> aspeed_pwm_tach_remove() can be removed. With that, priv->reset can
> become a local variable in aspeed_pwm_tach_probe().
I'll be happy to apply a follow-up patch making this change.
Thanks,
Guenter
Powered by blists - more mailing lists