linux-kernel - Re: [RFC RFT PATCH 0/4] Handle set_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 7 Mar 2024 19:12:19 +0000
From: "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
To: "linux-coco@...ts.linux.dev" <linux-coco@...ts.linux.dev>,
	"mhklinux@...look.com" <mhklinux@...look.com>, "dave.hansen@...ux.intel.com"
	<dave.hansen@...ux.intel.com>, "davem@...emloft.net" <davem@...emloft.net>,
	"haiyangz@...rosoft.com" <haiyangz@...rosoft.com>,
	"kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kys@...rosoft.com" <kys@...rosoft.com>,
	"Cui, Dexuan" <decui@...rosoft.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
	"wei.liu@...nel.org" <wei.liu@...nel.org>, "gregkh@...uxfoundation.org"
	<gregkh@...uxfoundation.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "sathyanarayanan.kuppuswamy@...ux.intel.com"
	<sathyanarayanan.kuppuswamy@...ux.intel.com>, "Reshetova, Elena"
	<elena.reshetova@...el.com>
Subject: Re: [RFC RFT PATCH 0/4] Handle  set_memory_XXcrypted() errors in
 hyperv

On Thu, 2024-03-07 at 17:11 +0000, Michael Kelley wrote:
> Using your patches plus the changes in my comments, I've
> done most of the testing described above. The normal
> paths work, and when I hack set_memory_encrypted()
> to fail, the error paths correctly did not free the memory.
> I checked both the ring buffer memory and the additional
> vmalloc memory allocated by the netvsc driver and the uio
> driver.  The memory status can be checked after-the-fact
> via /proc/vmmallocinfo and /proc/buddyinfo since these
> are mostly large allocations. As expected, the drivers
> output their own error messages after the failures to
> teardown the GPADLs.
> 
> I did not test the vmbus_disconnect() path since that
> effectively kills the VM.
> 
> I tested in a normal VM, and in an SEV-SNP VM.  I didn't
> specifically test in a TDX VM, but given that Hyper-V CoCo
> guests run with a paravisor, the guest sees the same thing
> either way.

Thanks Michael! How would you feel about reposting the patches with
your changes added? I think you have a very good handle on the part of
the problem I understand, and additionally much more familiarity with
these drivers.