linux-kernel - Re: [PATCH 2/2] usb: gadget: tegra-xudc: Fix USB3 PHY retrieval logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cc0eef54-28a4-41a8-9768-70c89c1601a9@nvidia.com>
Date: Thu, 7 Mar 2024 02:55:42 +0000
From: Wayne Chang <waynec@...dia.com>
To: Greg KH <gregkh@...uxfoundation.org>
CC: Jon Hunter <jonathanh@...dia.com>, "thierry.reding@...il.com"
	<thierry.reding@...il.com>, JC Kuo <jckuo@...dia.com>, "vkoul@...nel.org"
	<vkoul@...nel.org>, "kishon@...nel.org" <kishon@...nel.org>,
	"linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH 2/2] usb: gadget: tegra-xudc: Fix USB3 PHY retrieval logic

Hi Greg,

Thanks for the review.

On 3/6/24 06:10, Greg KH wrote:
> External email: Use caution opening links or attachments
>
>
> On Wed, Mar 06, 2024 at 12:11:22AM +0800, Wayne Chang wrote:
>> This commit resolves an issue in the tegra-xudc USB gadget driver that
>> incorrectly fetched USB3 PHY instances. The problem stemmed from the
>> assumption of a one-to-one correspondence between USB2 and USB3 PHY
>> names and their association with physical USB ports in the device tree.
>>
>> Previously, the driver associated USB3 PHY names directly with the USB3
>> instance number, leading to mismatches when mapping the physical USB
>> ports. For instance, if using USB3-1 PHY, the driver expect the
>> corresponding PHY name as 'usb3-1'. However, the physical USB ports in
>> the device tree were designated as USB2-0 and USB3-0 as we only have
>> one device controller, causing a misalignment.
>>
>> This commit rectifies the issue by adjusting the PHY naming logic.
>> Now, the driver correctly correlates the USB2 and USB3 PHY instances,
>> allowing the USB2-0 and USB3-1 PHYs to form a physical USB port pair
>> while accurately reflecting their configuration in the device tree by
>> naming them USB2-0 and USB3-0, respectively.
>>
>> The change ensures that the PHY and PHY names align appropriately,
>> resolving the mismatch between physical USB ports and their associated
>> names in the device tree.
>>
>> Fixes: b4e19931c98a ("usb: gadget: tegra-xudc: Support multiple device modes")
>> Cc: stable@...r.kernel.org
> You mark patch 2/2 for stable, but not patch 1/2?  That's not going to
> work well, is it?  :(

Yes, sorry about that. I'll update in the next patchset.

> thanks,
>
> greg k-h
>
thanks,

Wayne.