linux-kernel - Re: [PATCH] lib/fonts: Allow Sparc console 8x16 font for sparc64 early boot text console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZeoJhSUFeL_GhlRA@gallifrey>
Date: Thu, 7 Mar 2024 18:37:57 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Andreas Larsson <andreas@...sler.com>
Cc: sparclinux@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>,
	Michael Ellerman <mpe@...erman.id.au>,
	Sam Ravnborg <sam@...nborg.org>,
	Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH] lib/fonts: Allow Sparc console 8x16 font for sparc64
 early boot text console

* Andreas Larsson (andreas@...sler.com) wrote:
> Allow FONT_SUN8x16 when EARLYFB is enabled for sparc64, even when
> FRAMEBUFFER_CONSOLE is not to avoid the following warning for this case
> 
>    WARNING: unmet direct dependencies detected for FONT_SUN8x16
>      Depends on [n]: FONT_SUPPORT [=y] && (FRAMEBUFFER_CONSOLE [=n] && (FONTS [=n] || SPARC [=y]) || BOOTX_TEXT)
>      Selected by [y]:
>      - EARLYFB [=y] && SPARC64 [=y]
> 
> by allowing it in the same manner as is done for powerpc in commit
> 0ebc7feae79a ("powerpc: Use shared font data").

Yeh that looks like it should do it; I was hoping there was a way to make
that line simpler, but hey, thanks for fixing it.

Reviewed-by: Dr. David Alan Gilbert <linux@...blig.org>

> Signed-off-by: Andreas Larsson <andreas@...sler.com>
> Fixes: 0f1991949d9b ("sparc: Use shared font data")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202402241539.epQT43nI-lkp@intel.com/
> Cc: "Dr. David Alan Gilbert" <linux@...blig.org>
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Sam Ravnborg <sam@...nborg.org>
> Cc: Randy Dunlap <rdunlap@...radead.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> ---
> The commit this fixes can be found on my for-next branch from
> https://git.kernel.org/pub/scm/linux/kernel/git/alarsson/linux-sparc.git/
> ---
>  lib/fonts/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/fonts/Kconfig b/lib/fonts/Kconfig
> index 7ee468ef21ec6..7e945fdcbf115 100644
> --- a/lib/fonts/Kconfig
> +++ b/lib/fonts/Kconfig
> @@ -98,7 +98,8 @@ config FONT_10x18
>  
>  config FONT_SUN8x16
>  	bool "Sparc console 8x16 font"
> -	depends on (FRAMEBUFFER_CONSOLE && (FONTS || SPARC)) || BOOTX_TEXT
> +	depends on (FRAMEBUFFER_CONSOLE && (FONTS || SPARC)) || \
> +		   BOOTX_TEXT || EARLYFB
>  	help
>  	  This is the high resolution console font for Sun machines. Say Y.
>  
> 
> base-commit: 626db6ee8ee1edac206610db407114aa83b53fd3
> -- 
> 2.34.1
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/