[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAFBinCC2n+Muu2qaAG0PWFj6f+bVFDtHnzm78jSpeodTD47TOg@mail.gmail.com>
Date: Thu, 7 Mar 2024 21:56:55 +0100
From: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To: Mukesh Ojha <quic_mojha@...cinc.com>
Cc: srinivas.kandagatla@...aro.org, neil.armstrong@...aro.org,
khilman@...libre.com, jbrunet@...libre.com,
linux-arm-kernel@...ts.infradead.org, linux-amlogic@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvmem: meson-mx-efuse: Remove nvmem_device from efuse struct
Hello Mukesh,
On Tue, Mar 5, 2024 at 7:58 AM Mukesh Ojha <quic_mojha@...cinc.com> wrote:
>
> nvmem_device is used at one place while registering nvmem
> device and it is not required to be present in efuse struct
> for just this purpose.
>
> Drop nvmem_device and manage with nvmem device stack variable.
I'm generally fine with this approach
[...]
> @@ -223,9 +222,9 @@ static int meson_mx_efuse_probe(struct platform_device *pdev)
> return PTR_ERR(efuse->core_clk);
> }
>
> - efuse->nvmem = devm_nvmem_register(&pdev->dev, &efuse->config);
> + nvmem = devm_nvmem_register(&pdev->dev, &efuse->config);
But this doesn't compile for me:
CC drivers/nvmem/meson-mx-efuse.o
./drivers/nvmem/meson-mx-efuse.c: In function 'meson_mx_efuse_probe':
./drivers/nvmem/meson-mx-efuse.c:252:9: error: 'nvmem' undeclared
(first use in this function)
252 | nvmem = devm_nvmem_register(&pdev->dev, &efuse->config);
Best regards,
Martin
Powered by blists - more mailing lists