linux-kernel - Re: [PATCH 1/2] virt: efi_secret: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 7 Mar 2024 01:20:33 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: Dov Murik <dovmurik@...ux.ibm.com>, Dan Williams <dan.j.williams@...el.com>, 
	Gerd Hoffmann <kraxel@...hat.com>, kernel@...gutronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] virt: efi_secret: Convert to platform remove callback
 returning void

On Wed, 6 Mar 2024 at 22:35, Uwe Kleine-König
<u.kleine-koenig@...gutronix.de> wrote:
>
> Hello,
>
> On Tue, Dec 26, 2023 at 02:28:02PM +0100, Uwe Kleine-König wrote:
> > The .remove() callback for a platform driver returns an int which makes
> > many driver authors wrongly assume it's possible to do error handling by
> > returning an error code. However the value returned is ignored (apart
> > from emitting a warning) and this typically results in resource leaks.
> >
> > To improve here there is a quest to make the remove callback return
> > void. In the first step of this quest all drivers are converted to
> > .remove_new(), which already returns void. Eventually after all drivers
> > are converted, .remove_new() will be renamed to .remove().
> >
> > Trivially convert this driver from always returning zero in the remove
> > callback to the void returning variant.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>
> Is this patch still on someone's radar? If a resend would help, please
> tell me.
>

I've queued this up in the EFI tree.

Thanks,