linux-kernel - Re: [PATCH] tty: serial: amba-pl011: Fix removal of the QDF2xxx workarounds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024030741-numbness-unshaved-8c03@gregkh>
Date: Thu, 7 Mar 2024 21:45:58 +0000
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Thierry Reding <thierry.reding@...il.com>
Cc: Marek Szyprowski <m.szyprowski@...sung.com>,
	linux-kernel@...r.kernel.org, Russell King <linux@...linux.org.uk>,
	Jiri Slaby <jirislaby@...nel.org>,
	Konrad Dybcio <konrad.dybcio@...aro.org>
Subject: Re: [PATCH] tty: serial: amba-pl011: Fix removal of the QDF2xxx
 workarounds

On Thu, Feb 01, 2024 at 12:29:55PM +0100, Thierry Reding wrote:
> On Wed Jan 31, 2024 at 10:35 PM CET, Marek Szyprowski wrote:
> > Commit 196f34af2bf4 ("tty: serial: amba-pl011: Remove QDF2xxx
> > workarounds") removed some quirks specific to QDF2xxx SoC family.
> > Unfortunately it removed a bit too much code from the
> > pl011_console_match() function, what broke console operation on QEMU's
> > 'virt' ARM/ARM64 machines. Restore the "pl011" related string check as it
> > was originally introduced in the commit 10879ae5f12e ("serial: pl011: add
> > console matching function").
> >
> > Fixes: 196f34af2bf4 ("tty: serial: amba-pl011: Remove QDF2xxx workarounds")
> > Signed-off-by: Marek Szyprowski <m.szyprowski@...sung.com>
> > ---
> >  drivers/tty/serial/amba-pl011.c | 3 +++
> >  1 file changed, 3 insertions(+)
> 
> I was about to send out the same patch:
> 
> Reviewed-by: Thierry Reding <treding@...dia.com>

Oops, I applied this, but will drop it, as it's already fixed up in my
tree with a different commit.

thanks,

greg k-h