linux-kernel - Re: [PATCH v2 2/2] media: i2c: Add imx283 camera sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 8 Mar 2024 01:13:14 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Umang Jain <umang.jain@...asonboard.com>
Cc: linux-media@...r.kernel.org, Sakari Ailus <sakari.ailus@...ux.intel.com>, 
	Kieran Bingham <kieran.bingham@...asonboard.com>, 
	Laurent Pinchart <laurent.pinchart@...asonboard.com>, willl will <will@...lwhang.com>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Hans Verkuil <hverkuil-cisco@...all.nl>, 
	Hans de Goede <hdegoede@...hat.com>, Tomi Valkeinen <tomi.valkeinen@...asonboard.com>, 
	Alain Volmat <alain.volmat@...s.st.com>, Paul Elder <paul.elder@...asonboard.com>, 
	Mehdi Djait <mehdi.djait@...tlin.com>, Bingbu Cao <bingbu.cao@...el.com>, 
	Sebastian Reichel <sre@...nel.org>, Jacopo Mondi <jacopo.mondi@...asonboard.com>, 
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] media: i2c: Add imx283 camera sensor driver

On Fri, Mar 8, 2024 at 1:11 AM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Thu, Mar 7, 2024 at 11:41 PM Umang Jain <umang.jain@...asonboard.com> wrote:
> >
> > From: Kieran Bingham <kieran.bingham@...asonboard.com>
> >
> > Add a v4l2 subdevice driver for the Sony IMX283 image sensor.
> >
> > The IMX283 is a 20MP Diagonal 15.86 mm (Type 1) CMOS Image Sensor with
> > Square Pixel for Color Cameras.
> >
> > The following features are supported:
> > - Manual exposure an gain control support

and

> > - vblank/hblank/link freq control support
> > - Test pattern support control
> > - Arbitrary horizontal and vertical cropping
> > - Supported resolution:
> >   - 5472x3648 @ 20fps (SRGGB12)
> >   - 5472x3648 @ 25fps (SRGGB10)
> >   - 2736x1824 @ 50fps (SRGGB12)

..

> + array_size.h
> + bitops.h
> + container_of.h
>
> > +#include <linux/clk.h>
> > +#include <linux/delay.h>
>
> + errno.h

Actually err.h.

> > +#include <linux/gpio/consumer.h>
> > +#include <linux/i2c.h>

And
+ minmax.h

> > +#include <linux/module.h>
>
> + mutex.h
>
> > +#include <linux/of.h>
>
> How is this being used, please?
>
> > +#include <linux/pm_runtime.h>
>
> + property.h
>
> > +#include <linux/regulator/consumer.h>
>
> + types.h
>
> > +#include <linux/units.h>


-- 
With Best Regards,
Andy Shevchenko