linux-kernel - RE: [PATCH] drivers: clk: zynqmp: remove clock name dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PH7PR12MB7284F36E51750D47102410448A202@PH7PR12MB7284.namprd12.prod.outlook.com>
Date: Thu, 7 Mar 2024 06:06:45 +0000
From: "Trivedi Manojbhai, Naman" <Naman.TrivediManojbhai@....com>
To: Stephen Boyd <sboyd@...nel.org>, "Simek, Michal" <michal.simek@....com>,
	"robh@...nel.org" <robh@...nel.org>
CC: "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] drivers: clk: zynqmp: remove clock name dependency

Hi Stephen,

>-----Original Message-----
>From: Stephen Boyd <sboyd@...nel.org>
>Sent: Thursday, January 4, 2024 6:30 AM
>To: Trivedi Manojbhai, Naman <Naman.TrivediManojbhai@....com>;
>abel.vesa@...aro.org; angelogioacchino.delregno@...labora.com;
>krzysztof.kozlowski@...aro.org; Simek, Michal <michal.simek@....com>;
>mturquette@...libre.com; robh@...nel.org
>Cc: linux-clk@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
>kernel@...r.kernel.org; Trivedi Manojbhai, Naman
><Naman.TrivediManojbhai@....com>
>Subject: Re: [PATCH] drivers: clk: zynqmp: remove clock name dependency
>
>Caution: This message originated from an External Source. Use proper caution
>when opening attachments, clicking links, or responding.
>
>
>Quoting Naman Trivedi Manojbhai (2024-01-02 23:20:17)
>> Currently, from zynqmp_get_parent_list() function the clock driver
>> references the clock by name instead of its reference from device tree.
>> This causes problem when the clock name in the device tree is changed.
>>
>> Remove hard dependency of clock name and update the logic to use clock
>> reference from device tree instead of clock name.
>
>Please use struct clk_parent_data instead.
Thanks for review. As per my understanding, you suggest to replace the proposed
logic, and use "struct clk_parent_data" to get the clock name from device tree.

I have gone through other drivers which use the "struct clk_parent_data" structure, they have hard coded clock names in the driver. In zynqmp, the driver receives clock name from firmware.

Also, the "zynqmp_get_parent_list" function is called before clocks are
registered. So at this point, we don't have the hw structure which has
clk_parent_data.

So, I did not get how to use the struct clk_parent_data in this case. Can you please provide an example which I can look at as a reference?

Thanks,
Naman