linux-kernel - Re: [PATCH] btrfs: clean up some inconsistent indenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 7 Mar 2024 18:23:34 +1030
From: Qu Wenruo <quwenruo.btrfs@....com>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, clm@...com
Cc: josef@...icpanda.com, dsterba@...e.com, linux-btrfs@...r.kernel.org,
 linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] btrfs: clean up some inconsistent indenting



在 2024/3/7 17:17, Jiapeng Chong 写道:
> No functional modification involved.
>
> fs/btrfs/volumes.c:770 device_list_add() warn: inconsistent indenting.
> fs/btrfs/volumes.c:1373 btrfs_scan_one_device() warn: inconsistent indenting.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8453
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Can the bot be taught to watch the btrfs development branch
(https://github.com/btrfs/linux.git for-next) and send feedback directly
to the btrfs mailing list?
So that we can catch the problem immediately before reaching mainline.

I strongly doubt sending out such patches would leave any positive
impression on the bot.

Thanks,
Qu
> ---
>   fs/btrfs/volumes.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index a2d07fa3cfdf..caa3e83b0d6c 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -767,7 +767,7 @@ static noinline struct btrfs_device *device_list_add(const char *path,
>   		if (same_fsid_diff_dev) {
>   			generate_random_uuid(fs_devices->fsid);
>   			fs_devices->temp_fsid = true;
> -		pr_info("BTRFS: device %s (%d:%d) using temp-fsid %pU\n",
> +			pr_info("BTRFS: device %s (%d:%d) using temp-fsid %pU\n",
>   				path, MAJOR(path_devt), MINOR(path_devt),
>   				fs_devices->fsid);
>   		}
> @@ -1370,8 +1370,9 @@ struct btrfs_device *btrfs_scan_one_device(const char *path, blk_mode_t flags,
>   		else
>   			btrfs_free_stale_devices(devt, NULL);
>
> -	pr_debug("BTRFS: skip registering single non-seed device %s (%d:%d)\n",
> -			path, MAJOR(devt), MINOR(devt));
> +		pr_debug("BTRFS: skip registering single non-seed device %s (%d:%d)\n",
> +			 path, MAJOR(devt), MINOR(devt));
> +
>   		device = NULL;
>   		goto free_disk_super;
>   	}