linux-kernel - Re: [PATCH 2/4] siox: Provide a devm variant of siox_master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nuchb5aaywc5vr6cof4gqbavq4rkte3hvzgs6au3lbg6s6wlq4@bvbjevbum7kc>
Date: Thu, 7 Mar 2024 09:38:07 +0100
From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Thorsten Scherer <t.scherer@...elmann.de>, 
	linux-kernel@...r.kernel.org, Pengutronix Kernel Team <kernel@...gutronix.de>
Subject: Re: [PATCH 2/4] siox: Provide a devm variant of siox_master_alloc()

Hello Greg,

On Thu, Mar 07, 2024 at 07:29:59AM +0000, Greg Kroah-Hartman wrote:
> On Thu, Mar 07, 2024 at 08:13:55AM +0100, Uwe Kleine-König wrote:
> > On Mon, Feb 19, 2024 at 08:46:30AM +0100, Uwe Kleine-König wrote:
> > > +struct siox_master *devm_siox_master_alloc(struct device *dev,
> > > +					   size_t size)
> > > +{
> > > +	struct siox_master *smaster;
> > > +	int ret;
> > > +
> > > +	smaster = siox_master_alloc(dev, size);
> > > +	if (!smaster)
> > > +		return NULL;
> > > +
> > > +	ret = devm_add_action_or_reset(dev, devm_siox_master_put, smaster);
> > > +	if (ret)
> > > +		return NULL;
> > > +
> > > +	return smaster;
> > > +}
> > 
> > Here is missing an EXPORT_SYMBOL_GPL for devm_siox_master_alloc(). I
> > squashed this into to commit I created. Find the fixed commit at
> > 
> > 	https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git siox/for-next
> 
> Can you send me a "real" git pull request so that I can verify it is
> what you say it is (ideally with a signed tag)?

Sure, can do. I will do that tomorrow when (and if) my branch is in next
and so got a bit more exposure.

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)