linux-kernel - Re: [PATCH net-next] net: dsa: Leverage core stats allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZemDwNQnyPXbtMcz@gmail.com>
Date: Thu, 7 Mar 2024 01:07:12 -0800
From: Breno Leitao <leitao@...ian.org>
To: Florian Fainelli <florian.fainelli@...adcom.com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>,
	Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: Leverage core stats allocator

On Wed, Mar 06, 2024 at 12:04:09PM -0800, Florian Fainelli wrote:
> With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core
> and convert veth & vrf"), stats allocation could be done on net core
> instead of in this driver.
> 
> With this new approach, the driver doesn't have to bother with error
> handling (allocation failure checking, making sure free happens in the
> right spot, etc). This is core responsibility now.
> 
> Remove the allocation in the DSA user network device code and leverage
> the network core allocation instead.
> 
> Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>

Reviewed-by: Breno Leitao <leitao@...ian.org>