linux-kernel - Re: [PATCH v2 12/14] regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu,  7 Mar 2024 14:45:53 +0530
From: Bhargav Raviprakash <bhargav.r@...s.com>
To: broonie@...nel.org
Cc: arnd@...db.de,
	bhargav.r@...s.com,
	conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	gregkh@...uxfoundation.org,
	jpanis@...libre.com,
	kristo@...nel.org,
	krzysztof.kozlowski+dt@...aro.org,
	lee@...nel.org,
	lgirdwood@...il.com,
	linus.walleij@...aro.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	m.nirmaladevi@...s.com,
	nm@...com,
	robh+dt@...nel.org,
	vigneshr@...com
Subject: Re: [PATCH v2 12/14] regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators

Hi,
On Thu, 29 Feb 2024 13:58:54 +0000, Mark Brown wrote:
> On Fri, Feb 23, 2024 at 03:06:59PM +0530, Bhargav Raviprakash wrote:
> 
> > +static struct tps6594_regulator_irq_type tps65224_ext_regulator_irq_types[] = {
> > +	{ TPS65224_IRQ_NAME_VCCA_UVOV, "VCCA", "voltage out of range",
> > +	  REGULATOR_EVENT_OVER_VOLTAGE_WARN },
> > +	{ TPS65224_IRQ_NAME_VMON1_UVOV, "VMON1", "voltage out of range",
> > +	  REGULATOR_EVENT_OVER_VOLTAGE_WARN },
> > +	{ TPS65224_IRQ_NAME_VMON2_UVOV, "VMON2", "voltage out of range",
> > +	  REGULATOR_EVENT_OVER_VOLTAGE_WARN },
> > +};
> 
> These should be REGULATOR_EVENT_REGULATION_OUT I think - they look like
> they could be warning on either under or over voltage.

Thanks for the feedback.
In the next version we will use REGULATOR_EVENT_REGULATION_OUT.

Regards,
Bhargav