linux-kernel - Re: [PATCH v2 5/6] ACPI: NUMA: Remove ARCH depends option in ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJve8o=BsR1SG0k_7mb61Jj1fb+9rc4V9Y=MMX004fpAWE4vjg@mail.gmail.com>
Date: Thu, 7 Mar 2024 17:19:52 +0800
From: Haibo Xu <xiaobo55x@...il.com>
To: Arnd Bergmann <arnd@...db.de>
Cc: Haibo Xu <haibo1.xu@...el.com>, Alison Schofield <alison.schofield@...el.com>, 
	Jisheng Zhang <jszhang@...nel.org>, "Rafael J . Wysocki" <rafael@...nel.org>, 
	Dave Hansen <dave.hansen@...ux.intel.com>, Björn Töpel <bjorn@...osinc.com>, 
	"Conor.Dooley" <conor.dooley@...rochip.com>, guoren <guoren@...nel.org>, 
	Zong Li <zong.li@...ive.com>, James Morse <james.morse@....com>, 
	linux-riscv@...ts.infradead.org, Ard Biesheuvel <ardb@...nel.org>, 
	Baoquan He <bhe@...hat.com>, acpica-devel@...ts.linux.dev, 
	Robert Moore <robert.moore@...el.com>, linux-acpi@...r.kernel.org, 
	Sami Tolvanen <samitolvanen@...gle.com>, Greentime Hu <greentime.hu@...ive.com>, 
	Dan Williams <dan.j.williams@...el.com>, Len Brown <lenb@...nel.org>, 
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alexghiti@...osinc.com>, 
	Charlie Jenkins <charlie@...osinc.com>, Chen Jiahao <chenjiahao16@...wei.com>, 
	Yuntao Wang <ytcoode@...il.com>, Paul Walmsley <paul.walmsley@...ive.com>, 
	Clément Léger <cleger@...osinc.com>, 
	Anup Patel <apatel@...tanamicro.com>, Tony Luck <tony.luck@...el.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org, 
	Samuel Holland <samuel.holland@...ive.com>, Evan Green <evan@...osinc.com>, 
	Palmer Dabbelt <palmer@...belt.com>, Andrew Jones <ajones@...tanamicro.com>
Subject: Re: [PATCH v2 5/6] ACPI: NUMA: Remove ARCH depends option in
 ACPI_NUMA Kconfig

On Thu, Mar 7, 2024 at 4:44 PM Arnd Bergmann <arnd@...db.de> wrote:
>
> On Thu, Mar 7, 2024, at 09:47, Haibo Xu wrote:
> > x86/arm64/loongarch would select ACPI_NUMA by default and riscv
> > would do the same thing, so the dependency is no longer needed
> > since these are the four architectures that support ACPI.
> >
> > Suggested-by: Arnd Bergmann <arnd@...db.de>
> > Suggested-by: Sunil V L <sunilvl@...tanamicro.com>
> > Signed-off-by: Haibo Xu <haibo1.xu@...el.com>
> > ---
> >  drivers/acpi/numa/Kconfig | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/acpi/numa/Kconfig b/drivers/acpi/numa/Kconfig
> > index 849c2bd820b9..2bf47ad1ec9b 100644
> > --- a/drivers/acpi/numa/Kconfig
> > +++ b/drivers/acpi/numa/Kconfig
> > @@ -2,7 +2,6 @@
> >  config ACPI_NUMA
> >       bool "NUMA support"
> >       depends on NUMA
> > -     depends on (X86 || ARM64 || LOONGARCH)
> >       default y if ARM64
>
> Can we remove the prompt as well and make this a
> hidden option? I think this is now always selected
> when it can be used anyway.
>
> If we make it
>
>       def_bool NUMA && !X86
>
> then the select statements except for the X86_64_ACPI_NUMA
> can also go away.
>

Good idea!
Shall we include the ACPI in the def_bool definition?

>       Arnd