linux-kernel - Re: [PATCH 1/1] nvme: Use pr_dbg, not pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc6c4d98-e56a-448d-b372-38ce0cd927e9@nvidia.com>
Date: Thu, 7 Mar 2024 11:28:52 +0200
From: Max Gurtovoy <mgurtovoy@...dia.com>
To: Len Brown <lenb@...nel.org>, kbusch@...nel.org,
 linux-nvme@...ts.infradead.org
Cc: maxg@...lanox.com, axboe@...nel.dk, hch@....de, sagi@...mberg.me,
 linux-kernel@...r.kernel.org, Len Brown <len.brown@...el.com>
Subject: Re: [PATCH 1/1] nvme: Use pr_dbg, not pr_info, when setting shutdown
 timeout



On 07/03/2024 3:05, Len Brown wrote:
> From: Len Brown <len.brown@...el.com>
> 
> Some words are alarming in routine kernel messages.
> "timeout" is one of them...
> 
> Here NVME is routinely setting a timeout value,
> rather than reporting that a timeout has occurred.

No.
see the original commit message

"When an NVMe controller reports RTD3 Entry Latency larger than the 
value of shutdown_timeout module parameter, we update the 
shutdown_timeout accordingly to honor RTD3 Entry Latency. Use an 
informational debug level instead of a warning level for it."

So this is not a routine flow. This informs users about using a 
different value than the module param they set.



> 
> Assuming this message is actually useful to somebody somewhere,
> let's make it DEBUG level...

why ?
I don't think it is necessary.
> 
> Fixes: 1a3838d732ea ("nvme: modify the debug level for setting shutdown timeout")

This doesn't sounds like a bug fix to me.

> 
> Signed-off-by: Len Brown <len.brown@...el.com>
> ---
>   drivers/nvme/host/core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 0a96362912ce..e361af1953a4 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -3205,7 +3205,7 @@ static int nvme_init_identify(struct nvme_ctrl *ctrl)
>   						 shutdown_timeout, 60);
>   
>   		if (ctrl->shutdown_timeout != shutdown_timeout)
> -			dev_info(ctrl->device,
> +			dev_dbg(ctrl->device,
>   				 "Shutdown timeout set to %u seconds\n",
>   				 ctrl->shutdown_timeout);
>   	} else