linux-kernel - Re: [PATCH v2] dt-bindings: rtc: zynqmp: Add support for Versal/Versal NET SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f12831aa-036c-41c6-b3cd-fa1bd86546cf@amd.com>
Date: Thu, 7 Mar 2024 10:43:28 +0100
From: Michal Simek <michal.simek@....com>
To: Conor Dooley <conor@...nel.org>
Cc: linux-kernel@...r.kernel.org, monstr@...str.eu, michal.simek@...inx.com,
 git@...inx.com, Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Conor Dooley <conor+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Rob Herring <robh+dt@...nel.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>,
 "moderated list:ARM/ZYNQ ARCHITECTURE"
 <linux-arm-kernel@...ts.infradead.org>,
 "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" <linux-rtc@...r.kernel.org>
Subject: Re: [PATCH v2] dt-bindings: rtc: zynqmp: Add support for
 Versal/Versal NET SoCs



On 3/6/24 18:53, Conor Dooley wrote:
> On Wed, Mar 06, 2024 at 01:36:34PM +0100, Michal Simek wrote:
>> Add support for Versal and Versal NET SoCs. Both of them should use the
>> same IP core but differences can be in integration part that's why create
>> separate compatible strings.
>>
>> Also describe optional power-domains property. It is optional because power
>> domain doesn't need to be onwed by non secure firmware hence no access to
>> control it via any driver.
>>
>> Signed-off-by: Michal Simek <michal.simek@....com>
>> ---
>>
>> Changes in v2:
>> - Change subject
>> - Add compatible string for versal and versal NET
>> - Update commit message to reflect why power domain is optional.
>>
>>   .../devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml          | 8 +++++++-
>>   1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml
>> index d1f5eb996dba..5652df8ec121 100644
>> --- a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml
>> +++ b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml
>> @@ -18,7 +18,10 @@ allOf:
>>   
>>   properties:
>>     compatible:
>> -    const: xlnx,zynqmp-rtc
>> +    enum:
>> +      - xlnx,versal-rtc
>> +      - xlnx,versal-net-rtc
>> +      - xlnx,zynqmp-rtc
> 
> You sure chief? I don't see a driver patch alongside this adding these
> new versal compatibles there, so should these versal compatibles not
> fall back to the zynqmp one?

works for me too.

Thanks,
Michal