linux-kernel - Re: [PATCH v7 5/7] scsi: hisi_sas: Add libsas SATA sysfs attributes group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZemQBLMcJP617WDC@ryzen>
Date: Thu, 7 Mar 2024 10:59:32 +0100
From: Niklas Cassel <cassel@...nel.org>
To: John Garry <john.g.garry@...cle.com>
Cc: Igor Pylypiv <ipylypiv@...gle.com>, Damien Le Moal <dlemoal@...nel.org>,
	Jason Yan <yanaijie@...wei.com>,
	"James E.J. Bottomley" <jejb@...ux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Jack Wang <jinpu.wang@...ud.ionos.com>,
	Hannes Reinecke <hare@...e.de>,
	Xiang Chen <chenxiang66@...ilicon.com>,
	Artur Paszkiewicz <artur.paszkiewicz@...el.com>,
	Bart Van Assche <bvanassche@....org>,
	TJ Adams <tadamsjr@...gle.com>, linux-ide@...r.kernel.org,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 5/7] scsi: hisi_sas: Add libsas SATA sysfs attributes
 group

On Thu, Mar 07, 2024 at 08:55:51AM +0000, John Garry wrote:
> On 06/03/2024 20:56, Igor Pylypiv wrote:
> > > > ---
> > > >   drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 6 ++++++
> > > >   drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 6 ++++++
> > > Is there a reason why you didn't patch:
> > > drivers/scsi/hisi_sas/hisi_sas_v1_hw.c ?
> > > 
> > I originally patched hisi_sas_v1_hw.c as well. John Garry pointed out
> > that v1 HW doesn't support SATA so I dropped the change.
> 
> If you are going to do another spin, then maybe update the commit message
> with this.

+1


John, now I'm curious, do you know why hisi_sas_v1_hw.c is implemented
as a libsas driver (instead of a regular SCSI driver), if it doesn't
support SATA?

Was perhaps v2_hw and v3_hw implemented as a libsas driver first
(since they support SATA), and v1_hw support was added later,
so that it could reuse much of the parts of the existing driver?


Kind regards,
Niklas