linux-kernel - Re: [PATCH] phy: rockchip: Fix typo in function names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAEEuhrxR14nrVqeqV_OfHjqkMaKx1S6KzcnsJqr02VUnS8oyA@mail.gmail.com>
Date: Thu, 7 Mar 2024 11:01:03 +0100
From: Rick Wertenbroek <rick.wertenbroek@...il.com>
To: rick.wertenbroek@...g-vd.ch
Cc: Vinod Koul <vkoul@...nel.org>, Kishon Vijay Abraham I <kishon@...nel.org>, 
	Heiko Stuebner <heiko@...ech.de>, linux-phy@...ts.infradead.org, 
	linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] phy: rockchip: Fix typo in function names

On Thu, Mar 7, 2024 at 10:54 AM Rick Wertenbroek
<rick.wertenbroek@...il.com> wrote:
>
> Several functions had "rochchip" instead of "rockchip" in their name.
> Replace "rochchip" by "rockchip".
>
> Signed-off-By: Rick Wertenbroek <rick.wertenbroek@...il.com>
> ---
>  drivers/phy/rockchip/phy-rockchip-naneng-combphy.c |  4 ++--
>  drivers/phy/rockchip/phy-rockchip-snps-pcie3.c     | 12 ++++++------
>  2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
> index 76b9cf417591..35d5c18661a3 100644
> --- a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
> +++ b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
> @@ -245,7 +245,7 @@ static int rockchip_combphy_exit(struct phy *phy)
>         return 0;
>  }
>
> -static const struct phy_ops rochchip_combphy_ops = {
> +static const struct phy_ops rockchip_combphy_ops = {
>         .init = rockchip_combphy_init,
>         .exit = rockchip_combphy_exit,
>         .owner = THIS_MODULE,
> @@ -352,7 +352,7 @@ static int rockchip_combphy_probe(struct platform_device *pdev)
>                 return ret;
>         }
>
> -       priv->phy = devm_phy_create(dev, NULL, &rochchip_combphy_ops);
> +       priv->phy = devm_phy_create(dev, NULL, &rockchip_combphy_ops);
>         if (IS_ERR(priv->phy)) {
>                 dev_err(dev, "failed to create combphy\n");
>                 return PTR_ERR(priv->phy);
> diff --git a/drivers/phy/rockchip/phy-rockchip-snps-pcie3.c b/drivers/phy/rockchip/phy-rockchip-snps-pcie3.c
> index 121e5961ce11..3cdc7625b308 100644
> --- a/drivers/phy/rockchip/phy-rockchip-snps-pcie3.c
> +++ b/drivers/phy/rockchip/phy-rockchip-snps-pcie3.c
> @@ -187,7 +187,7 @@ static const struct rockchip_p3phy_ops rk3588_ops = {
>         .phy_init = rockchip_p3phy_rk3588_init,
>  };
>
> -static int rochchip_p3phy_init(struct phy *phy)
> +static int rockchip_p3phy_init(struct phy *phy)
>  {
>         struct rockchip_p3phy_priv *priv = phy_get_drvdata(phy);
>         int ret;
> @@ -210,7 +210,7 @@ static int rochchip_p3phy_init(struct phy *phy)
>         return ret;
>  }
>
> -static int rochchip_p3phy_exit(struct phy *phy)
> +static int rockchip_p3phy_exit(struct phy *phy)
>  {
>         struct rockchip_p3phy_priv *priv = phy_get_drvdata(phy);
>
> @@ -219,9 +219,9 @@ static int rochchip_p3phy_exit(struct phy *phy)
>         return 0;
>  }
>
> -static const struct phy_ops rochchip_p3phy_ops = {
> -       .init = rochchip_p3phy_init,
> -       .exit = rochchip_p3phy_exit,
> +static const struct phy_ops rockchip_p3phy_ops = {
> +       .init = rockchip_p3phy_init,
> +       .exit = rockchip_p3phy_exit,
>         .set_mode = rockchip_p3phy_set_mode,
>         .owner = THIS_MODULE,
>  };
> @@ -280,7 +280,7 @@ static int rockchip_p3phy_probe(struct platform_device *pdev)
>                 return priv->num_lanes;
>         }
>
> -       priv->phy = devm_phy_create(dev, NULL, &rochchip_p3phy_ops);
> +       priv->phy = devm_phy_create(dev, NULL, &rockchip_p3phy_ops);
>         if (IS_ERR(priv->phy)) {
>                 dev_err(dev, "failed to create combphy\n");
>                 return PTR_ERR(priv->phy);
> --
> 2.25.1
>

Compiled and tested on RK3588 boards (FriendlyElec NanoPC-T6, and CM3588).
"grep -rni rochchip ." inside the kernel folder to make sure no
occurrence was missed.

Best regards,
Rick