linux-kernel - Re: [PATCH 2/2] mips: dts: ralink: mt7621: add serial1 and serial2 nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMhs-H9WyQZsvEvCfUcZ0_eU8--EzxEmaxR50wdRFDGP3E64ZQ@mail.gmail.com>
Date: Thu, 7 Mar 2024 11:04:31 +0100
From: Sergio Paracuellos <sergio.paracuellos@...il.com>
To: Justin Swartz <justin.swartz@...ingedge.co.za>
Cc: Arınç ÜNAL <arinc.unal@...nc9.com>, 
	Rob Herring <robh+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>, Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, linux-mips@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 2/2] mips: dts: ralink: mt7621: add serial1 and serial2 nodes

Hi Justin,

On Wed, Mar 6, 2024 at 9:11 PM Justin Swartz
<justin.swartz@...ingedge.co.za> wrote:
>
> Add serial1 and serial2 nodes to define the existence of
> UART1 and UART2.
>
> Signed-off-by: Justin Swartz <justin.swartz@...ingedge.co.za>
> ---
>  arch/mips/boot/dts/ralink/mt7621.dtsi | 38 +++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>
> diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
> index dca415fdd..2069249c8 100644
> --- a/arch/mips/boot/dts/ralink/mt7621.dtsi
> +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
> @@ -128,6 +128,44 @@ serial0: serial@c00 {
>                         pinctrl-0 = <&uart1_pins>;
>                 };
>
> +               serial1: serial@d00 {
> +                       status = "disabled";
> +
> +                       compatible = "ns16550a";
> +                       reg = <0xd00 0x100>;
> +
> +                       clocks = <&sysc MT7621_CLK_UART2>;
> +
> +                       interrupt-parent = <&gic>;
> +                       interrupts = <GIC_SHARED 27 IRQ_TYPE_LEVEL_HIGH>;
> +
> +                       reg-shift = <2>;
> +                       reg-io-width = <4>;
> +                       no-loopback-test;
> +
> +                       pinctrl-names = "default";
> +                       pinctrl-0 = <&uart2_pins>;
> +               };
> +
> +               serial2: serial@e00 {
> +                       status = "disabled";
> +
> +                       compatible = "ns16550a";
> +                       reg = <0xe00 0x100>;
> +
> +                       clocks = <&sysc MT7621_CLK_UART3>;
> +
> +                       interrupt-parent = <&gic>;
> +                       interrupts = <GIC_SHARED 28 IRQ_TYPE_LEVEL_HIGH>;
> +
> +                       reg-shift = <2>;
> +                       reg-io-width = <4>;
> +                       no-loopback-test;
> +
> +                       pinctrl-names = "default";
> +                       pinctrl-0 = <&uart3_pins>;
> +               };
> +

Please follow the preferred order for properties described in dts
coding style [0]. I know that there is some mess around the properties
order in some nodes with the current dtsi file but we did not have
coding style before and now we have it, so I think we should follow it
at least for new additions.

Best regards,
    Sergio Paracuellos

[0]: https://docs.kernel.org/devicetree/bindings/dts-coding-style.html