linux-kernel - Re: [PATCH] platform/mellanox: mlxreg-hotplug: Remove redundant NULL-check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <170980618467.1921.15643030796886976535.b4-ty@linux.intel.com>
Date: Thu, 07 Mar 2024 12:09:44 +0200
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Vadim Pasternak <vadimp@...dia.com>, Daniil Dulov <d.dulov@...ddin.ru>
Cc: Mark Gross <mgross@...ux.intel.com>, 
 Andy Shevchenko <andy@...radead.org>, Darren Hart <dvhart@...radead.org>, 
 Hans de Goede <hdegoede@...hat.com>, platform-driver-x86@...r.kernel.org, 
 linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] platform/mellanox: mlxreg-hotplug: Remove redundant
 NULL-check

On Wed, 06 Mar 2024 18:38:04 +0300, Daniil Dulov wrote:

> Pointer item is checked fo NULL at mlxreg_hotplug_work_helper() and then
> it is dereferenced to produce dev_err().
> This pointer is also dereferenced before calling this function and should
> never be NULL except some piece of hardware is broken as it is said in
> the comment before the check. So, this check can be safely removed.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/mellanox: mlxreg-hotplug: Remove redundant NULL-check
      commit: 576b82c3c9bf021af4984aafc105508c99660667

--
 i.