linux-kernel - [PATCH] hwmon: (amc6821) add of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240307-amc6821-of-match-v1-1-5f40464a3110@solid-run.com>
Date: Thu, 07 Mar 2024 12:06:58 +0100
From: Josua Mayer <josua@...id-run.com>
To: Jean Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>
Cc: Yazan Shhady <yazan.shhady@...id-run.com>, 
 Jon Nettleton <jon@...id-run.com>, linux-hwmon@...r.kernel.org, 
 linux-kernel@...r.kernel.org, stable@...r.kernel.org, 
 Josua Mayer <josua@...id-run.com>, Rabeeh Khoury <rabeeh@...id-run.com>
Subject: [PATCH] hwmon: (amc6821) add of_match table

Add of_match table for "ti,amc6821" compatible string.
This fixes automatic driver loading by userspace when using device-tree,
and if built as a module like major linux distributions do.

While devices probe just fine with i2c_device_id table, userspace can't
match the "ti,amc6821" compatible string from dt with the plain
"amc6821" device id. COnsequently kernel module ca not be loaded.

Cc: stable@...r.kernel.org
Signed-off-by: Josua Mayer <josua@...id-run.com>
---
Bcc: Rabeeh Khoury <rabeeh@...id-run.com>
---
 drivers/hwmon/amc6821.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/hwmon/amc6821.c b/drivers/hwmon/amc6821.c
index 2a7a4b6b0094..9b02b304c2f5 100644
--- a/drivers/hwmon/amc6821.c
+++ b/drivers/hwmon/amc6821.c
@@ -934,10 +934,21 @@ static const struct i2c_device_id amc6821_id[] = {
 
 MODULE_DEVICE_TABLE(i2c, amc6821_id);
 
+static const struct of_device_id __maybe_unused amc6821_of_match[] = {
+	{
+		.compatible = "ti,amc6821",
+		.data = (void *)amc6821,
+	},
+	{ }
+};
+
+MODULE_DEVICE_TABLE(of, amc6821_of_match);
+
 static struct i2c_driver amc6821_driver = {
 	.class = I2C_CLASS_HWMON,
 	.driver = {
 		.name	= "amc6821",
+		.of_match_table = of_match_ptr(amc6821_of_match),
 	},
 	.probe = amc6821_probe,
 	.id_table = amc6821_id,

---
base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
change-id: 20240307-amc6821-of-match-3e3308fbf133

Best regards,
-- 
Josua Mayer <josua@...id-run.com>