linux-kernel - Re: [EXTERNAL] Re: [PATCH v10] The tas2783 is a smart audio amplifier with integrated MIPI SoundWire interface (Version 1.2.1 compliant), I2C, and I2S/TDM interfaces designed for portable applications. An on-chip DSP supports Texas Instruments SmartAmp sp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <73a4416f-4738-485d-aa5a-431c306e7023@sirena.org.uk>
Date: Thu, 7 Mar 2024 11:39:55 +0000
From: Mark Brown <broonie@...nel.org>
To: "Ding, Shenghao" <shenghao-ding@...com>
Cc: "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"perex@...ex.cz" <perex@...ex.cz>,
	"pierre-louis.bossart@...ux.intel.com" <pierre-louis.bossart@...ux.intel.com>,
	"13916275206@....com" <13916275206@....com>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"liam.r.girdwood@...el.com" <liam.r.girdwood@...el.com>,
	"bard.liao@...el.com" <bard.liao@...el.com>,
	"mengdong.lin@...el.com" <mengdong.lin@...el.com>,
	"yung-chuan.liao@...ux.intel.com" <yung-chuan.liao@...ux.intel.com>,
	"Xu, Baojun" <baojun.xu@...com>, "Lu, Kevin" <kevin-lu@...com>,
	"tiwai@...e.de" <tiwai@...e.de>, "soyer@....hu" <soyer@....hu>,
	"Baojun.Xu@....com" <Baojun.Xu@....com>,
	"Navada Kanyana, Mukund" <navada@...com>
Subject: Re: [EXTERNAL] Re: [PATCH v10] The tas2783 is a smart audio
 amplifier with integrated MIPI SoundWire interface (Version 1.2.1
 compliant), I2C, and I2S/TDM interfaces designed for portable applications.
 An on-chip DSP supports Texas Instruments SmartAmp sp

On Thu, Mar 07, 2024 at 03:56:40AM +0000, Ding, Shenghao wrote:

> > We also try to keep default settings from the silicon except in the most
> > obvious cases, it avoids issues with trying to work out what to set and
> > accomodate different use cases for different systems.

> > If you do need to set non-default values then either just regular writes during
> > probe or a regmap patch would do it.

> So, can I remove 
> ".reg_defaults = tas2783_reg_defaults," and tas2783_reg_defaults from the code?

Yes, supplying register defaults is completely optional.  It means we
can't omit default values from cache sync and have to read values back
from the device the first time we read but those tend to be fairly minor
performance impacts.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)