[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bc361325-1510-4fe0-a7ee-bc5be0a1b4cc@kernel.org>
Date: Thu, 7 Mar 2024 14:38:38 +0200
From: Roger Quadros <rogerq@...nel.org>
To: Théo Lebrun <theo.lebrun@...tlin.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, Peter Chen <peter.chen@...nel.org>,
Pawel Laszczak <pawell@...ence.com>, Nishanth Menon <nm@...com>,
Vignesh Raghavendra <vigneshr@...com>, Tero Kristo <kristo@...nel.org>
Cc: Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
Grégory Clement <gregory.clement@...tlin.com>,
Kevin Hilman <khilman@...nel.org>, Alan Stern <stern@...land.harvard.edu>,
linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 5/9] usb: cdns3-ti: pass auxdata from match data to
of_platform_populate()
On 07/03/2024 11:55, Théo Lebrun wrote:
> Allow compatible to pick auxdata given to child platform devices.
>
> No compatible exploits this functionality, just yet.
>
This patch could be merged with Patch 7 so we know exactly how auxdata
is used?
> Signed-off-by: Théo Lebrun <theo.lebrun@...tlin.com>
> ---
> drivers/usb/cdns3/cdns3-ti.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/cdns3/cdns3-ti.c b/drivers/usb/cdns3/cdns3-ti.c
> index f76327566798..29fb24c811b3 100644
> --- a/drivers/usb/cdns3/cdns3-ti.c
> +++ b/drivers/usb/cdns3/cdns3-ti.c
> @@ -62,7 +62,8 @@ struct cdns_ti {
> };
>
> struct cdns_ti_match_data {
> - bool reset_on_resume;
> + bool reset_on_resume;
> + const struct of_dev_auxdata *auxdata;
> };
>
> static const int cdns_ti_rate_table[] = { /* in KHZ */
> @@ -95,6 +96,7 @@ static int cdns_ti_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct device_node *node = pdev->dev.of_node;
> + const struct of_dev_auxdata *auxdata = NULL;
> struct cdns_ti *data;
> unsigned long rate;
> int error, i;
> @@ -149,7 +151,9 @@ static int cdns_ti_probe(struct platform_device *pdev)
> goto err;
> }
>
> - error = of_platform_populate(node, NULL, NULL, dev);
> + if (data->match_data)
> + auxdata = data->match_data->auxdata;
> + error = of_platform_populate(node, NULL, auxdata, dev);
> if (error) {
> dev_err(dev, "failed to create children: %d\n", error);
> goto err;
>
--
cheers,
-roger
Powered by blists - more mailing lists