linux-kernel - Re: [PATCH v1 1/1] s390/cio: Use while (i--) pattern to clean up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 7 Mar 2024 14:54:42 +0100
From: Heiko Carstens <hca@...ux.ibm.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        Vineeth Vijayan <vneethv@...ux.ibm.com>,
        Peter Oberparleiter <oberpar@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>
Subject: Re: [PATCH v1 1/1] s390/cio: Use while (i--) pattern to clean up

On Mon, Mar 04, 2024 at 04:43:18PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 22, 2024 at 03:45:01PM +0200, Andy Shevchenko wrote:
> > Use more natural while (i--) patter to clean up allocated resources.
> 
> Any comments?

It is up to Vineeth and Peter to decide what to do with this.

But in general I'm not a fan of such patches. It depends on what people
prefer, and you can send literally thousands of similar patches where the
code looks "more natural" afterwards.