linux-kernel - Re: [PATCH] pinctrl: aw9523: allow building as loadable module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYOofmWd6=_XN0+FWDJjp0W8vV_deUZbNOr2n5BkGaL4w@mail.gmail.com>
Date: Thu, 7 Mar 2024 15:34:15 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>, 
	David Bauer <mail@...id-bauer.net>, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, 
	Arnd Bergmann <arnd@...db.de>, Andy Shevchenko <andy.shevchenko@...il.com>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: aw9523: allow building as loadable module

On Thu, Mar 7, 2024 at 3:07 PM Arnd Bergmann <arnd@...nel.org> wrote:


> When CONFIG_I2C is set to =m, the new aw9523 driver fails to link:
>
> arm-linux-gnueabi-ld: drivers/pinctrl/pinctrl-aw9523.o: in function `aw9523_probe':
> pinctrl-aw9523.c:(.text+0x9f8): undefined reference to `__devm_regmap_init_i2c'
> arm-linux-gnueabi-ld: drivers/pinctrl/pinctrl-aw9523.o: in function `aw9523_driver_init':
> pinctrl-aw9523.c:(.init.text+0x4): undefined reference to `i2c_register_driver'
> arm-linux-gnueabi-ld: drivers/pinctrl/pinctrl-aw9523.o: in function `aw9523_driver_exit':
> pinctrl-aw9523.c:(.exit.text+0x2): undefined reference to `i2c_del_driver'
>
> Make it a tristate symbol so the dependency is correctly honored.
>
> Fixes: bfa5aa367a82 ("pinctrl: Add driver for Awinic AW9523/B I2C GPIO Expander")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

I sent something similar yesterday:
https://lore.kernel.org/linux-gpio/20240305-fix-aw9523-v2-1-2dc50bab2b17@linaro.org/

Thanks anyway!

Yours,
Linus Walleij