linux-kernel - Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom: update compatible name for match with driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqLbbRFijBXS5CyRm0P4FMY7bR3UUdgXA7xP4Z1oRevnzQ@mail.gmail.com>
Date: Fri, 8 Mar 2024 14:10:34 -0600
From: Rob Herring <robh+dt@...nel.org>
To: Tengfei Fan <quic_tengfan@...cinc.com>
Cc: andersson@...nel.org, konrad.dybcio@...aro.org, linus.walleij@...aro.org, 
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, 
	linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, kernel@...cinc.com
Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom: update compatible name
 for match with driver

On Tue, Feb 27, 2024 at 7:37 AM Rob Herring <robh+dt@...nel.org> wrote:
>
> On Mon, Jan 29, 2024 at 3:25 AM Tengfei Fan <quic_tengfan@...cinccom> wrote:
> >
> > Use compatible name "qcom,sm4450-tlmm" instead of "qcom,sm4450-pinctrl"
> > to match the compatible name in sm4450 pinctrl driver.
> >
> > Fixes: 7bf8b78f86db ("dt-bindings: pinctrl: qcom: Add SM4450 pinctrl")
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> > Signed-off-by: Tengfei Fan <quic_tengfan@...cinc.com>
> > ---
> >  Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmmyaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
> > index bb08ca5a1509..bb675c8ec220 100644
> > --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
> > @@ -17,7 +17,7 @@ allOf:
> >
> >  properties:
> >    compatible:
> > -    const: qcom,sm4450-pinctrl
> > +    const: qcom,sm4450-tlmm
>
> I think you forgot to update the example:
>
> Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.example.dtb:
> /example-0/pinctrl@...0000: failed to match any schema with
> compatible: ['qcom,sm4450-tlmm']

Still a warning in linux-next. Please send a fix.

Rob