linux-kernel - Re: [PATCH] liquidio: Fix potential null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 8 Mar 2024 20:19:11 +0000
From: Simon Horman <horms@...nel.org>
To: Aleksandr Mishin <amishin@...rgos.ru>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Kees Cook <keescook@...omium.org>,
	Justin Stitt <justinstitt@...gle.com>,
	Felix Manlunas <felix.manlunas@...ium.com>,
	Satanand Burla <satananda.burla@...ium.com>,
	Raghu Vatsavayi <raghu.vatsavayi@...ium.com>,
	Vijaya Mohan Guvva <vijaya.guvva@...ium.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	lvc-project@...uxtesting.org
Subject: Re: [PATCH] liquidio: Fix potential null pointer dereference

On Thu, Mar 07, 2024 at 12:29:32PM +0300, Aleksandr Mishin wrote:
> In lio_vf_rep_copy_packet() pg_info->page is compared to a NULL value,
> but then it is unconditionally passed to skb_add_rx_frag() which could
> lead to null pointer dereference.
> Fix this bug by moving skb_add_rx_frag() into conditional scope.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 1f233f327913 (liquidio: switchdev support for LiquidIO NIC)

A correct format for the tag above is:

Fixes: 1f233f327913 ("liquidio: switchdev support for LiquidIO NIC")

> Signed-off-by: Aleksandr Mishin <amishin@...rgos.ru>

I guess this code is never hit.
But I agree this should be fixed.

Reviewed-by: Simon Horman <horms@...nel.org>