linux-kernel - Re: [PATCH] firmware: qcom_scm: remove IS_ERR() checks from qcom_scm_bw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b8b1064b-a3d5-4b33-918a-2cef60b5c59d@linaro.org>
Date: Fri, 8 Mar 2024 23:00:30 +0100
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Gabor Juhos <j4g8y7@...il.com>, Bjorn Andersson <andersson@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: qcom_scm: remove IS_ERR() checks from
 qcom_scm_bw_{en,dis}able()

On 8.03.2024 10:25, Gabor Juhos wrote:
> Since the qcom_scm_probe() function returns with an error if
> __scm->path contains an error pointer, it is not needed to
> verify that again in the qcom_scm_bw_{en,dis}able() functions
> so remove the superfluous IS_ERR() checks.
> 
> Signed-off-by: Gabor Juhos <j4g8y7@...il.com>
> ---
> Based on v6.8-rc7.
> ---

LGTM

Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad