linux-kernel - RE: v6.8.0-rc6: mei_ace_probe / mei_vsc_probe: do not call blocking ops when !TASK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <MW5PR11MB5787E3A96C8EFF3C9F8BC8908D272@MW5PR11MB5787.namprd11.prod.outlook.com>
Date: Fri, 8 Mar 2024 23:45:44 +0000
From: "Wu, Wentong" <wentong.wu@...el.com>
To: Dominik Brodowski <linux@...inikbrodowski.net>, Sakari Ailus
	<sakari.ailus@...ux.intel.com>
CC: "Winkler, Tomas" <tomas.winkler@...el.com>, "mchehab@...nel.org"
	<mchehab@...nel.org>, "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: v6.8.0-rc6: mei_ace_probe / mei_vsc_probe: do not call blocking
 ops when !TASK_RUNNING

Hi Dominik,

Did you try master branch (v6.8) without IPU6 driver? There
should be problems with the IPU6 driver you use as below:

> intel-ipu6 0000:00:05.0: Found supported sensor OVTI01A0:00
> intel-ipu6 0000:00:05.0: Connected 1 cameras

If not, could you please help try it on your side? Thanks a lot

BR,
Wentong
> From: Dominik Brodowski <linux@...inikbrodowski.net>
> 
> Hi Sakari,
> 
> Am Thu, Feb 29, 2024 at 07:30:33AM +0000 schrieb Sakari Ailus:
> > On Thu, Feb 29, 2024 at 08:21:42AM +0100, Dominik Brodowski wrote:
> > > Hi Sakari,
> > >
> > > many thanks, this patch helps. Another issue persists, though:
> > >
> > >
> > > $ dmesg | cut -c16- | grep -E "(mei|vsc)"
> > > mei_me 0000:00:16.0: enabling device (0000 -> 0002) mei_hdcp
> > > 0000:00:16.0-b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound
> > > 0000:00:02.0 (ops i915_hdcp_ops) mei_pxp
> > > 0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1: bound
> > > 0000:00:02.0 (ops i915_pxp_tee_component_ops) intel_vsc intel_vsc:
> > > silicon stepping version is 0:2 mei
> > > intel_vsc-92335fcf-3203-4472-af93-7b4453ac29da: deferred probe
> > > pending: (reason unknown) mei
> > > intel_vsc-5db76cf6-0a68-4ed6-9b78-0361635e2447: deferred probe
> > > pending: (reason unknown)
> >
> > You'll probably need the IPU bridge patches from that branch, too. Or
> > you can try removing the intel-ipu6 driver and modprobing it again.
> 
> Everything is built into the kernel here - and the kernel I run is pure
> upstream (plus your patch), therefore no intel-ipu6 driver is available
> (yet) or active.
> 
> > > During suspend entry (s2idle), the following messages are emitted:
> > >
> > > ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments -
> > > Caller passed 0, method requires 1 (20230628/nsarguments-232)
> > > intel_vsc intel_vsc: silicon stepping version is 0:2
> > > PM: Some devices failed to suspend, or early wake event detected
> > > ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments -
> > > Caller passed 0, method requires 1 (20230628/nsarguments-232)
> > > intel_vsc intel_vsc: silicon stepping version is 0:2 vsc-tp
> > > spi-INTC1094:00: wakeup firmware failed ret: -110 vsc-tp
> > > spi-INTC1094:00: wakeup firmware failed ret: -110 intel_vsc
> > > intel_vsc: wait fw ready failed: -110 intel_vsc intel_vsc: hw_start
> > > failed ret = -110 fw status = intel_vsc intel_vsc: unexpected reset:
> > > dev_state = RESETTING fw status = ACPI Warning:
> > > \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed
> > > 0, method requires 1 (20230628/nsarguments-232) intel_vsc intel_vsc:
> > > silicon stepping version is 0:2
> >
> > I haven't tried suspending. Is this while streaming or not?
> 
> No streaming - in fact, without intel-ipu6 available (upstream + your patch,
> see above).
> 
> 
> I have now tried upstream plus the ipu6 branch; there I get one message
> indicating that something is amiss:
> 
> 	vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
> 
> And if I try to do a suspend&resume cycle, the machine hangs. A longer
> snippet from dmesg from upstream+ipu6 branch:
> 
> mei_me 0000:00:16.0: enabling device (0000 -> 0002) mei_hdcp 0000:00:16.0-
> b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound 0000:00:02.0 (ops
> i915_hdcp_ops) mei_pxp 0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-
> 1bab8cbe36b1: bound 0000:00:02.0 (ops i915_pxp_tee_component_ops)
> intel-ipu6 0000:00:05.0: enabling device (0000 -> 0002)
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925 intel_vsc intel_vsc: silicon
> stepping version is 0:2
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925 vsc-tp spi-INTC1094:00:
> wakeup firmware failed ret: -110
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: Found supported sensor OVTI01A0:00
> intel-ipu6 0000:00:05.0: Connected 1 cameras
> intel-ipu6 0000:00:05.0: IPU6-v3[465d] hardware version 5
> 
> 
> Best,
> 	Dominik