linux-kernel - Re: [PATCH v3] ssb: Fix potential NULL pointer dereference in ssb_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240308055049.50a830fc@barney>
Date: Fri, 8 Mar 2024 05:50:49 +0100
From: Michael Büsch <m@...s.ch>
To: James Dutton <james.dutton@...il.com>
Cc: Rand Deeb <rand.sec96@...il.com>, deeb.rand@...fident.ru,
 jonas.gorski@...il.com, khoroshilov@...ras.ru, kvalo@...nel.org,
 linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
 lvc-project@...uxtesting.org, voskresenski.stanislav@...fident.ru
Subject: Re: [PATCH v3] ssb: Fix potential NULL pointer dereference in
 ssb_device_uevent

On Thu, 7 Mar 2024 22:02:29 +0000
James Dutton <james.dutton@...il.com> wrote:

> If one does a NULL check after it has been previously dereferenced,
> the compiler will totally remove the NULL check anyway,

I think the kernel uses -fno-delete-null-pointer-checks.

But anyway, this doesn't invalidate the point of having a NULL check.
The intent of the code was very clear.
So don't remove it.

-- 
Michael Büsch
https://bues.ch/

Content of type "application/pgp-signature" skipped