linux-kernel - Re: [PATCH] Input: synaptics-rmi4 - fix UAF of IRQ domain on driver removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZepZv98s4cHR24E1@google.com>
Date: Thu, 7 Mar 2024 16:20:15 -0800
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Mathias Krause <minipli@...ecurity.net>
Cc: Torsten Hilbrich <torsten.hilbrich@...unet.com>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	Nick Dyer <nick@...anahar.org>,
	Brad Spengler <spender@...ecurity.net>,
	Sasha Levin <sashal@...nel.org>,
	Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: synaptics-rmi4 - fix UAF of IRQ domain on driver
 removal

On Thu, Feb 22, 2024 at 03:26:54PM +0100, Mathias Krause wrote:
> Calling irq_domain_remove() will lead to freeing the IRQ domain
> prematurely. The domain is still referenced and will be attempted to get
> used via rmi_free_function_list() -> rmi_unregister_function() ->
> irq_dispose_mapping() -> irq_get_irq_data()'s ->domain pointer.
> 
> With PaX's MEMORY_SANITIZE this will lead to an access fault when
> attempting to dereference embedded pointers, as in Torsten's report that
> was faulting on the 'domain->ops->unmap' test.
> 
> Fix this by releasing the IRQ domain only after all related IRQs have
> been deactivated.
> 
> Fixes: 24d28e4f1271 ("Input: synaptics-rmi4 - convert irq distribution to irq_domain")
> Reported-by: Torsten Hilbrich <torsten.hilbrich@...unet.com>
> Signed-off-by: Mathias Krause <minipli@...ecurity.net>

Applied, thank you.

-- 
Dmitry