linux-kernel - Re: [PATCH] mips: dts: ralink: mt7621: add cell count properties to usb0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <28f260a7-d4a1-48b6-8387-af134b9a600d@linaro.org>
Date: Fri, 8 Mar 2024 08:39:21 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Justin Swartz <justin.swartz@...ingedge.co.za>
Cc: Arınç ÜNAL <arinc.unal@...nc9.com>,
 Sergio Paracuellos <sergio.paracuellos@...il.com>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 linux-mips@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] mips: dts: ralink: mt7621: add cell count properties to
 usb0

On 07/03/2024 15:58, Justin Swartz wrote:
> Hi Krzysztof
> 
> On 2024-03-07 10:01, Krzysztof Kozlowski wrote:
>> On 06/03/2024 21:21, Justin Swartz wrote:
>>> Add default #address-cells and #size-cells properties to usb0,
>>> suitable for hubs and devices without explicitly declared
>>> interface nodes, as:
>>>
>>>   "#address-cells":
>>>     description: should be 1 for hub nodes with device nodes,
>>>       should be 2 for device nodes with interface nodes.
>>>     enum: [1, 2]
>>>
>>>   "#size-cells":
>>>     const: 0
>>>
>>> -- from Documentation/devicetree/bindings/usb/usb-device.yaml
>>>
>>> Signed-off-by: Justin Swartz <justin.swartz@...ingedge.co.za>
>>> ---
>>>  arch/mips/boot/dts/ralink/mt7621.dtsi | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi 
>>> b/arch/mips/boot/dts/ralink/mt7621.dtsi
>>> index 2069249c8..f02965db1 100644
>>> --- a/arch/mips/boot/dts/ralink/mt7621.dtsi
>>> +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
>>> @@ -309,6 +309,9 @@ usb: usb@...c0000 {
>>>
>>>  		interrupt-parent = <&gic>;
>>>  		interrupts = <GIC_SHARED 22 IRQ_TYPE_LEVEL_HIGH>;
>>> +
>>> +		#address-cells = <1>;
>>> +		#size-cells = <0>;
>>
>> Doesn't this bring new W=1 warnings?
> 
> For a fresh build (make O=build clean; make O=build W=1): I do not 

make dtbs W=1 is enough

> receive any warnings regarding mt7621.dtsi or my board's .dts file. I 

I meant for other boards due to unnecessary address/size cells, but if
you checked it is fine.

Best regards,
Krzysztof