linux-kernel - Re: [PATCH] pps: clients: gpio: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d73b0a4-34e6-44ce-8757-4f4931c3da85@enneenne.com>
Date: Fri, 8 Mar 2024 09:57:29 +0100
From: Rodolfo Giometti <giometti@...eenne.com>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH] pps: clients: gpio: Convert to platform remove callback
 returning void

On 08/03/24 09:51, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> 
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Acked-by: Rodolfo Giometti <giometti@...eenne.com>

> ---
>   drivers/pps/clients/pps-gpio.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c
> index 2f4b11b4dfcd..791fdc9326dd 100644
> --- a/drivers/pps/clients/pps-gpio.c
> +++ b/drivers/pps/clients/pps-gpio.c
> @@ -220,7 +220,7 @@ static int pps_gpio_probe(struct platform_device *pdev)
>   	return 0;
>   }
>   
> -static int pps_gpio_remove(struct platform_device *pdev)
> +static void pps_gpio_remove(struct platform_device *pdev)
>   {
>   	struct pps_gpio_device_data *data = platform_get_drvdata(pdev);
>   
> @@ -229,7 +229,6 @@ static int pps_gpio_remove(struct platform_device *pdev)
>   	/* reset echo pin in any case */
>   	gpiod_set_value(data->echo_pin, 0);
>   	dev_info(&pdev->dev, "removed IRQ %d as PPS source\n", data->irq);
> -	return 0;
>   }
>   
>   static const struct of_device_id pps_gpio_dt_ids[] = {
> @@ -240,7 +239,7 @@ MODULE_DEVICE_TABLE(of, pps_gpio_dt_ids);
>   
>   static struct platform_driver pps_gpio_driver = {
>   	.probe		= pps_gpio_probe,
> -	.remove		= pps_gpio_remove,
> +	.remove_new	= pps_gpio_remove,
>   	.driver		= {
>   		.name	= PPS_GPIO_NAME,
>   		.of_match_table	= pps_gpio_dt_ids,
> 
> base-commit: 8ffc8b1bbd505e27e2c8439d326b6059c906c9dd

-- 
GNU/Linux Solutions                  e-mail: giometti@...eenne.com
Linux Device Driver                          giometti@...ux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming