linux-kernel - Re: [PATCH 1/2] arm64: dts: rockchip: enable internal pull-up for Q7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43d84aa9-ce0f-406e-82ac-2a691264ee23@theobroma-systems.com>
Date: Fri, 8 Mar 2024 10:33:51 +0100
From: Quentin Schulz <quentin.schulz@...obroma-systems.com>
To: Heiko Stübner <heiko@...ech.de>,
 Iskander Amara <iskander.amara@...obroma-systems.com>, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
 vahe.grigoryan@...obroma-systems.com,
 angelogioacchino.delregno@...labora.com, dsimic@...jaro.org,
 alexander.stein@...tq-group.com, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: rockchip: enable internal pull-up for
 Q7_THRM# on RK3399 Puma

Hi Heiko,

On 3/8/24 10:29, Heiko Stübner wrote:
> Am Freitag, 8. März 2024, 10:25:43 CET schrieb Quentin Schulz:
>> Hi Iskander,
>>
>> On 3/8/24 09:52, Iskander Amara wrote:
>>> Q7_THRM# pin is connected to a diode on the module which is used
>>> as a level shifter, and the pin have a pull-down enabled by
>>> default. We need to configure it to internal pull-up, other-
>>> wise whenever the pin is configured as INPUT and we try to
>>> control it externally the value will always remain zero.
>>>
>>> Signed-off-by: Iskander Amara <iskander.amara@...obroma-systems.com>
>>
>> For the whole series:
>>
>> Reviewed-by: Quentin Schulz <quentin.schulz@...obroma-systems.com>
>>
>> @Heiko I think this may match the criteria for stable backports?
> 
> at least patch1 does ... it definitly should have a Fixes tag though.
> 
> 

Fixes: 2c66fc34e945 ("arm64: dts: rockchip: add RK3399-Q7 (Puma) SoM")

I assume, since this issue existed since the introducing commit.

Cheers,
Quentin