linux-kernel - Re: [PATCH v19 001/130] x86/virt/tdx: Rename _offset to _member for TD_SYSINFO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c3ab761bf404f3b60e589f5f5369c7e229a9753.camel@intel.com>
Date: Fri, 8 Mar 2024 10:36:29 +0000
From: "Huang, Kai" <kai.huang@...el.com>
To: "binbin.wu@...ux.intel.com" <binbin.wu@...ux.intel.com>, "Yamahata, Isaku"
	<isaku.yamahata@...el.com>
CC: "Zhang, Tina" <tina.zhang@...el.com>, "seanjc@...gle.com"
	<seanjc@...gle.com>, "Yuan, Hang" <hang.yuan@...el.com>, "Chen, Bo2"
	<chen.bo@...el.com>, "sagis@...gle.com" <sagis@...gle.com>,
	"isaku.yamahata@...il.com" <isaku.yamahata@...il.com>, "Aktas, Erdem"
	<erdemaktas@...gle.com>, "kirill.shutemov@...ux.intel.com"
	<kirill.shutemov@...ux.intel.com>, "kvm@...r.kernel.org"
	<kvm@...r.kernel.org>, "pbonzini@...hat.com" <pbonzini@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v19 001/130] x86/virt/tdx: Rename _offset to _member for
 TD_SYSINFO_MAP() macro

On Fri, 2024-03-08 at 15:25 +0800, Binbin Wu wrote:
> 
> On 2/26/2024 4:25 PM, isaku.yamahata@...el.com wrote:
> > From: Kai Huang <kai.huang@...el.com>
> > 
> > TD_SYSINFO_MAP() macro actually takes the member of the 'struct
> > tdx_tdmr_sysinfo' as the second argument and uses the offsetof() to
> > calculate the offset for that member.
> > 
> > Rename the macro argument _offset to _member to reflect this.
> > 
> > Signed-off-by: Kai Huang <kai.huang@...el.com>
> > Reviewed-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> > Signed-off-by: Isaku Yamahata <isaku.yamahata@...el.com>
> 
> Reviewed-by: Binbin Wu <binbin.wu@...ux.intel.com>
> 
> 

Thanks for review.

I've sent out the first 5 metadata read patches as a standalone patchset
separately:

https://lore.kernel.org/kvm/cover.1709288433.git.kai.huang@intel.com/

I'll add your Reviewed-by in next version.

(for others please comment there instead, thanks!)