linux-kernel - Re: [PATCH][next] nvmet-fc: remove unused functions nvmet_fc_iodnum and nvmet_fc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8f4ec68d-ab2a-462d-8a65-d63931a12696@nvidia.com>
Date: Fri, 8 Mar 2024 00:12:52 +0000
From: Chaitanya Kulkarni <chaitanyak@...dia.com>
To: Colin Ian King <colin.i.king@...il.com>, James Smart
	<james.smart@...adcom.com>, Christoph Hellwig <hch@....de>, Sagi Grimberg
	<sagi@...mberg.me>, Chaitanya Kulkarni <chaitanyak@...dia.com>,
	"linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>
CC: "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] nvmet-fc: remove unused functions nvmet_fc_iodnum
 and nvmet_fc_fodnum

On 3/7/24 03:01, Colin Ian King wrote:
> The inlined helper functions nvmet_fc_iodnum and nvmet_fc_fodnum are
> not used and are redundant. They have been in the code since 2016 and
> never been referenced. Remove them.
>
> Cleans up clang scan warnings such as:
> drivers/nvme/target/fc.c:177:1: warning: unused function
> 'nvmet_fc_iodnum' [-Wunused-function]
>
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
>

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck