linux-kernel - Re: [PATCH v2 4/6] media: imx335: Use integer values for size registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZerxncwhQLgm3PMP@tom-HP-ZBook-Fury-15-G7-Mobile-Workstation>
Date: Fri, 8 Mar 2024 12:08:13 +0100
From: Tommaso Merciai <tomm.merciai@...il.com>
To: Umang Jain <umang.jain@...asonboard.com>
Cc: linux-media@...r.kernel.org,
	Alexander Shiyan <eagle.alexander923@...il.com>,
	Kieran Bingham <kieran.bingham@...asonboard.com>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	open list <linux-kernel@...r.kernel.org>,
	Dave Stevenson <dave.stevenson@...pberrypi.com>
Subject: Re: [PATCH v2 4/6] media: imx335: Use integer values for size
 registers

Hi Umang,

On Fri, Mar 08, 2024 at 02:03:10PM +0530, Umang Jain wrote:
> Consider integer values for registers that are related to various
> sizes in the register map. This helps in improving the overall
> readability.
> 
> No functional changes intended in this patch.
> 
> Signed-off-by: Umang Jain <umang.jain@...asonboard.com>
> ---
>  drivers/media/i2c/imx335.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c
> index ec27035586f3..3c593538f727 100644
> --- a/drivers/media/i2c/imx335.c
> +++ b/drivers/media/i2c/imx335.c
> @@ -250,12 +250,12 @@ static const struct cci_reg_sequence mode_2592x1940_regs[] = {
>  	{IMX335_REG_MODE_SELECT, 0x01},
>  	{IMX335_REG_MASTER_MODE, 0x00},
>  	{IMX335_REG_WINMODE, 0x04},
> -	{IMX335_REG_HTRIMMING_START, 0x0180},
> -	{IMX335_REG_HNUM, 0x0a20},
> -	{IMX335_REG_Y_OUT_SIZE, 0x0794},
> -	{IMX335_REG_AREA3_ST_ADR_1, 0x00b0},
> -	{IMX335_REG_AREA3_WIDTH_1, 0x0f58},
> -	{IMX335_REG_OPB_SIZE_V, 0x00},
> +	{IMX335_REG_HTRIMMING_START, 384},
> +	{IMX335_REG_HNUM, 2592},
> +	{IMX335_REG_Y_OUT_SIZE, 1940},
> +	{IMX335_REG_AREA3_ST_ADR_1, 176},
> +	{IMX335_REG_AREA3_WIDTH_1, 3928},
> +	{IMX335_REG_OPB_SIZE_V, 0},
>  	{IMX335_REG_XVS_XHS_DRV, 0x00},
>  	{CCI_REG8(0x3288), 0x21}, /* undocumented */
>  	{CCI_REG8(0x328a), 0x02}, /* undocumented */

Looks good to me.
Reviwed-by: Tommaso Merciai <tomm.merciai@...il.com>

Thanks & Regards,
Tommaso

> -- 
> 2.43.0
> 
>