linux-kernel - Re: [PATCH v6 0/2] zswap: remove the memcpy if acomp is not sleepable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGsJ_4wMGNDcgc3pqSUicYoH7Z_miczkT=uwZU+yhDF0fd57Rg@mail.gmail.com>
Date: Fri, 8 Mar 2024 19:57:38 +0800
From: Barry Song <21cnbao@...il.com>
To: akpm@...ux-foundation.org, herbert@...dor.apana.org.au
Cc: chriscli@...gle.com, chrisl@...nel.org, ddstreet@...e.org, 
	linux-kernel@...r.kernel.org, sjenning@...hat.com, vitaly.wool@...sulko.com, 
	Barry Song <v-songbaohua@...o.com>, davem@...emloft.net, hannes@...xchg.org, 
	linux-crypto@...r.kernel.org, linux-mm@...ck.org, zhouchengming@...edance.com, 
	nphamcs@...il.com, yosryahmed@...gle.com
Subject: Re: [PATCH v6 0/2] zswap: remove the memcpy if acomp is not sleepable

Hi Andrew,

On Thu, Feb 22, 2024 at 4:11 PM Barry Song <21cnbao@...il.com> wrote:
>
> From: Barry Song <v-songbaohua@...o.com>
>
> In zswap, if we use zsmalloc, we cannot sleep while we map the
> compressed memory, so we copy it to a temporary buffer. By
> knowing the alg won't sleep can help zswap to avoid the
> memcpy.
> Thus we introduce an API in crypto to expose if acomp is async,
> and zswap can use it to decide if it can remove copying to the
> tmp buffer.
>
> -v6:
>  * add acked-by of Herbert, Thanks!
>  * remove patch 3/3 from the series, as that one will go
>    through crypto

Can you please pull this into mm-tree? This used to have 3 patches.

3/3 was separated according to Herbert's requirements and has
been in a crypto tree.
crypto: scomp - remove memcpy if sg_nents is 1 and pages are lowmem
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=77292bb8ca

Two drivers fixes(patch 1 needs) have also been in crypto tree:
crypto: hisilicon/zip - fix the missing CRYPTO_ALG_ASYNC in cra_flags
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=db8ac88385

crypto: iaa - fix the missing CRYPTO_ALG_ASYNC in cra_flags
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=30dd94dba35

So it should be quite safe to pull this series into mm-tree now.

>
> Barry Song (2):
>   crypto: introduce: acomp_is_async to expose if comp drivers might
>     sleep
>   mm/zswap: remove the memcpy if acomp is not sleepable
>
>  include/crypto/acompress.h | 6 ++++++
>  mm/zswap.c                 | 6 ++++--
>  2 files changed, 10 insertions(+), 2 deletions(-)
>
> --
> 2.34.1

Thanks
Barry