linux-kernel - Re: [PATCH 10/10] sched/balancing: Update comments in 'struct sg_lb_stats' and 'struct sd_lb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKfTPtA+Y4MEkovYvkfnUQ09kyreD3mAD-LKiSsoBe=FsqSMrw@mail.gmail.com>
Date: Fri, 8 Mar 2024 13:01:24 +0100
From: Vincent Guittot <vincent.guittot@...aro.org>
To: Ingo Molnar <mingo@...nel.org>
Cc: linux-kernel@...r.kernel.org, Dietmar Eggemann <dietmar.eggemann@....com>, 
	Linus Torvalds <torvalds@...ux-foundation.org>, Peter Zijlstra <peterz@...radead.org>, 
	Shrikanth Hegde <sshegde@...ux.ibm.com>, Valentin Schneider <vschneid@...hat.com>
Subject: Re: [PATCH 10/10] sched/balancing: Update comments in 'struct
 sg_lb_stats' and 'struct sd_lb_stats'

On Fri, 8 Mar 2024 at 11:59, Ingo Molnar <mingo@...nel.org> wrote:
>
> - Align for readability
> - Capitalize consistently
>
> Signed-off-by: Ingo Molnar <mingo@...nel.org>
> Reviewed-by: Valentin Schneider <vschneid@...hat.com>
> Cc: Dietmar Eggemann <dietmar.eggemann@....com>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Shrikanth Hegde <sshegde@...ux.ibm.com>
> Cc: Vincent Guittot <vincent.guittot@...aro.org>

Reviewed-by: Vincent Guittot <vincent.guittot@...aro.org>

> ---
>  kernel/sched/fair.c | 19 +++++++++----------
>  1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 40b98e43d794..116a640534b9 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -9433,17 +9433,17 @@ static void update_blocked_averages(int cpu)
>  /********** Helpers for find_busiest_group ************************/
>
>  /*
> - * sg_lb_stats - stats of a sched_group required for load_balancing
> + * sg_lb_stats - stats of a sched_group required for load-balancing:
>   */
>  struct sg_lb_stats {
> -       unsigned long avg_load;                 /* Avg load across the CPUs of the group */
> -       unsigned long group_load;               /* Total load over the CPUs of the group */
> -       unsigned long group_capacity;
> -       unsigned long group_util;               /* Total utilization over the CPUs of the group */
> +       unsigned long avg_load;                 /* Avg load            over the CPUs of the group */
> +       unsigned long group_load;               /* Total load          over the CPUs of the group */
> +       unsigned long group_capacity;           /* Capacity            over the CPUs of the group */
> +       unsigned long group_util;               /* Total utilization   over the CPUs of the group */
>         unsigned long group_runnable;           /* Total runnable time over the CPUs of the group */
> -       unsigned int sum_nr_running;            /* Nr of tasks running in the group */
> +       unsigned int sum_nr_running;            /* Nr of all tasks running in the group */
>         unsigned int sum_h_nr_running;          /* Nr of CFS tasks running in the group */
> -       unsigned int idle_cpus;
> +       unsigned int idle_cpus;                 /* Nr of idle CPUs         in the group */
>         unsigned int group_weight;
>         enum group_type group_type;
>         unsigned int group_asym_packing;        /* Tasks should be moved to preferred CPU */
> @@ -9456,8 +9456,7 @@ struct sg_lb_stats {
>  };
>
>  /*
> - * sd_lb_stats - Structure to store the statistics of a sched_domain
> - *              during load balancing.
> + * sd_lb_stats - stats of a sched_domain required for load-balancing:
>   */
>  struct sd_lb_stats {
>         struct sched_group *busiest;            /* Busiest group in this sd */
> @@ -9465,7 +9464,7 @@ struct sd_lb_stats {
>         unsigned long total_load;               /* Total load of all groups in sd */
>         unsigned long total_capacity;           /* Total capacity of all groups in sd */
>         unsigned long avg_load;                 /* Average load across all groups in sd */
> -       unsigned int prefer_sibling;            /* tasks should go to sibling first */
> +       unsigned int prefer_sibling;            /* Tasks should go to sibling first */
>
>         struct sg_lb_stats busiest_stat;        /* Statistics of the busiest group */
>         struct sg_lb_stats local_stat;          /* Statistics of the local group */
> --
> 2.40.1
>