linux-kernel - Re: [PATCH v1 5/5] media: ir-spi: Unify indentation and comment style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 8 Mar 2024 13:37:01 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Sean Young <sean@...s.org>, Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH v1 5/5] media: ir-spi: Unify indentation and comment style

On Wed, Mar 06, 2024 at 03:35:56PM +0200, Andy Shevchenko wrote:
> On Tue, Mar 05, 2024 at 11:52:15PM +0100, Andi Shyti wrote:
> > On Tue, Mar 05, 2024 at 07:48:30PM +0200, Andy Shevchenko wrote:
> 
> ...
> 
> > > +static int ir_spi_tx(struct rc_dev *dev, unsigned int *buffer, unsigned int count)
> > 
> > this goes over 80 characters, though. Not an error, but not worth
> > a change either.
> 
> It's only 82 characters and I consider this as an improvement in readability.
> It's quite pity that some of the subsystems are too conservative, hope this
> one is not an obstacle for them.
> 
> > I'm not going block the patch as the rest is OK.
> > 
> > Reviewed-by: Andi Shyti <andi.shyti@...nel.org>
> 
> Thank you!
> 
> Btw, don't you want to either add your entry into .mailcap and/or update your
> email address in this source file (and maybe others)? I Cc'ed you only after
> I looked closer to the sources...

yes, will do... I also noticed that lots of updates are missing...

I've been far from all this for too long, so that I have still
a lot of catch up to do :-)

Thanks, Andy!
Andi